Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix feedback score issue #217

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix feedback score issue #217

wants to merge 3 commits into from

Conversation

phaabe
Copy link
Collaborator

@phaabe phaabe commented Oct 21, 2023

The bug came from ignoring that 'convinced' can be Optional.

This PR provides:

  • a fix
  • removal of the hot-fix

@phaabe phaabe added class:newcomer Good for newcomers to the project: easy and/or limited scope area:backend Related to the server component labels Oct 21, 2023
@phaabe phaabe requested a review from scy October 21, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scy scy Awaiting requested review from scy

Assignees

@scy scy

Labels
area:backend Related to the server component class:newcomer Good for newcomers to the project: easy and/or limited scope
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phaabe @scy