Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update default gradient step, turn off histogram matching #1831

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

cookpa
Copy link
Member

@cookpa cookpa commented Jan 24, 2025

Have left antsBrainExtraction.sh alone because I'm not sure if histogram matching is more important where Laplacians are involved

Trying to harmonize with #768 and #770 in ANTsPy.

There are a lot of specialized / old scripts that I didn't change, we should consider moving to a permanent archive.

Histogram matching also defaults to on in antsMotionCorr, but again that is kind of a specialized case

Have left antsBrainExtraction.sh alone because I'm not sure if histogram
matching is more important where Laplacians are involved
@cookpa cookpa marked this pull request as draft January 24, 2025 17:15
@cookpa
Copy link
Member Author

cookpa commented Jan 24, 2025

Converting to draft because I need to test the scripts

@cookpa cookpa marked this pull request as ready for review January 27, 2025 17:07
@cookpa
Copy link
Member Author

cookpa commented Jan 27, 2025

@cookpa cookpa merged commit 64803f1 into master Jan 27, 2025
2 checks passed
@cookpa cookpa deleted the histogram_match branch January 27, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant