PlaneBufferGeometry has been renamed to PlaneGeometry. #640
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [yaml](https://github.com/eemeli/yaml) from 2.2.1 to 2.3.2. - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v2.2.1...v2.3.2) --- updated-dependencies: - dependency-name: yaml dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
changed Twitter's old name to new one 𝕏
|
@ma2yama many thanks, looks good: let me test it. We have already fixed this issue in LocAR.js (see: https://github.com/AR-js-org/locar.js/blob/master/lib/src/webcam-renderer.js); however it hasn't been fixed in the main repo yet. One request, could you re-open your PR against |
|
For some reason these changes wasn't effective, probably during the merge process something went wrong. Thank you @ma2yama to note this. |
kalwalt
added
bug
|
@kalwalt yes, I did initially think that this had been updated already in the last release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes to avoid using the deprecated API.
Can it be referenced to an Issue? If so what is the issue # ?
No
How can we test it?
Use any of location-based examples with the modified code.
Summary
Since the API has been removed from Three.js, it has been modified to use a different API.
Does this PR introduce a breaking change?
No
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
iPhone 14 Pro, mobile Safari, iOS 17.7
Other information
mrdoob/three.js#26175