Skip to content

Commit

Permalink
Reinstate armv4t and armv5te compiler_rt and libcxx tests
Browse files Browse the repository at this point in the history
Pull request #109628 automatically turned on frame pointers for leaf functions
in Clang when frame pointers are enabled. This triggered a latent bug in
picolibc for armv4t and armv5te, which consequentially broke our tests for them.

There is currently a pull request that fixes this
bug (picolibc/picolibc#897), but we don't have to wait
for this to merge to reinstate the tests, because we recently changed the
behaviour of Clang to by default omit frame pointers altogether
(llvm/llvm-project#117140), and that is how picolibc is
built now. In general the advice is that you shouldn't build AArch32 targets
with frame pointers enabled for various reasons.
  • Loading branch information
stuij committed Dec 22, 2024
1 parent 59f5919 commit 8cfc242
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions arm-multilib/json/variants/armv4t.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
"picolibc": {
"PICOLIBC_BUILD_TYPE": "minsize",
"ENABLE_CXX_LIBS": "ON",
"ENABLE_LIBC_TESTS": "OFF",
"ENABLE_COMPILER_RT_TESTS": "OFF",
"ENABLE_LIBCXX_TESTS": "OFF"
"ENABLE_LIBC_TESTS": "ON",
"ENABLE_COMPILER_RT_TESTS": "ON",
"ENABLE_LIBCXX_TESTS": "ON"
},
"newlib": {
"ENABLE_CXX_LIBS": "ON",
Expand All @@ -38,4 +38,4 @@
"ENABLE_LIBCXX_TESTS": "OFF"
}
}
}
}
8 changes: 4 additions & 4 deletions arm-multilib/json/variants/armv5te.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
"picolibc": {
"PICOLIBC_BUILD_TYPE": "minsize",
"ENABLE_CXX_LIBS": "ON",
"ENABLE_LIBC_TESTS": "OFF",
"ENABLE_COMPILER_RT_TESTS": "OFF",
"ENABLE_LIBCXX_TESTS": "OFF"
"ENABLE_LIBC_TESTS": "ON",
"ENABLE_COMPILER_RT_TESTS": "ON",
"ENABLE_LIBCXX_TESTS": "ON"
},
"newlib": {
"ENABLE_CXX_LIBS": "ON",
Expand All @@ -38,4 +38,4 @@
"ENABLE_LIBCXX_TESTS": "OFF"
}
}
}
}

0 comments on commit 8cfc242

Please sign in to comment.