[Fix/#318] 방장 및 참여자 이름 입력 제한 글자수 8자로 변경 #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeunseo
changed the title
ljh0608
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌀 해당 이슈 번호
🔹 어떤 것을 변경했나요?
🔹 어떻게 구현했나요?
기존에 TextInput 공통컴포넌트에서, 글자수 제한을 15자로 하드코딩되어있었습니다.
TextInput이 쓰이는 곳마다 글자수 제한을 다르게 줄 필요가 있기 때문에 이 값을 prop으로 추가했습니다.
그리고 참여자 정보 입력 input과 방장 정보 입력 input에서 max값을 8자로 넘겨주도록 구현했습니다.
🔹 PR 포인트를 알려주세요!
🔹 스크린샷을 남겨주세요!
2024-08-21.2.03.33.mov