This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
Tidy up code base #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also fixes buffer overflows in PN5180ISO14443::mifareBlockWrite16() and PN5180ISO14443::mifareHalt() where the cmd buffer was 1 instead of the required 2 bytes long.
…o() when DEBUG is not set
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the code base. See the commit messages for what has been changed.
All changes should not change the API, the logic or add/remove any features.
The cleanup is splittet in several commits, so it should be easier to revert or cherry-pick specific changes. So if a change is not to taste, I will try to update the PR :)