Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug: find-tx-by-customer & duration not shown when add-tx with 1 day #217

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

SemiColonKen
Copy link

@SemiColonKen SemiColonKen commented Nov 11, 2024

to display exact input from customer and not lowercase input

when add-tx with 1 day duration, the display will show "1 day" now instead of "day"

@SemiColonKen SemiColonKen added this to the v2.1 milestone Nov 11, 2024
@SemiColonKen SemiColonKen self-assigned this Nov 11, 2024
Comment on lines 216 to 226
// Assert that each transaction is not null
assert transaction != null : "Transaction in the list should not be null.";
if (transaction.getCustomer().toLowerCase().contains(customer)) {
if (transaction.getCustomer().toLowerCase().contains(customer.toLowerCase())) {
found = true;
System.out.println(transaction);
}
}
if (!found) {
System.out.println("none");
System.out.println("None");
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@tkhahns tkhahns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SemiColonKen SemiColonKen changed the title Fixed bug: find-tx-by-customer Fixed bug: find-tx-by-customer & duration not shown when add-tx with 1 day Nov 11, 2024
@tkhahns tkhahns merged commit 76a4386 into AY2425S1-CS2113-T11-3:master Nov 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants