A-RexCodeQuality #221
Merged
A-RexCodeQuality #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexkoh425
requested review from
SemiColonKen,
AaronZZ10,
tkhahns and
CT9ARyan
|
LGTM!! |
CT9ARyan
reviewed
Nov 11, 2024
| @@ -67,4 +67,5 @@ activate CustomerList | |||
| Parser <-- CustomerList : return | |||
| deactivate CustomerList | |||
| deactivate Parser | |||
| hide footbox | |||
src/main/java/file/CustomerFile.java
Outdated
| try { | ||
| if(FileHandler.containEmptyParameter(parameters)){ |
There was a problem hiding this comment.
Maybe you could add a space here after the if and the closing ) bracket.
src/main/java/file/FileHandler.java
Outdated
| @@ -99,6 +100,15 @@ private static void createFolder() { | |||
| } | |||
| } | |||
|
|
|||
| public static boolean containEmptyParameter(String[] parameters){ | |||
| for(int i = 0; i < parameters.length ; i++){ | |||
There was a problem hiding this comment.
Same thing here maybe?? Add a space after the for??
| @@ -121,6 +126,7 @@ public void addTransactionWithParameters(String[] parameters , ArrayList<Integer | |||
| boolean isCompleted = Boolean.parseBoolean(parameters[5]); | |||
| Transaction transaction = new Transaction(transactionId , carLicensePlate, borrowerName, duration, | |||
| startDate, isCompleted); | |||
|
|
|||
| TransactionList.addTxWithoutPrintingInfo(transaction); | |||
| }catch (NumberFormatException | DateTimeParseException | CarException | TransactionException e){ | |||
There was a problem hiding this comment.
Maybe leave a space here before catch?
src/main/java/file/FileHandler.java
Outdated
| @@ -99,6 +100,15 @@ private static void createFolder() { | |||
| } | |||
| } | |||
|
|
|||
| public static boolean containEmptyParameter(String[] parameters){ | |||
| for(int i = 0; i < parameters.length ; i++){ | |||
| if(parameters[i].trim().isEmpty()){ | |||
| while (scanner.hasNext()) { | ||
| scanLineAndAddTransaction(scanner, errorLines, line); | ||
| line ++; | ||
| } | ||
|
|
||
| if(!errorLines.isEmpty()) { |
| @@ -89,6 +91,7 @@ public void loadTransactionDataIfExist(){ | |||
| public void scanLineAndAddTransaction(Scanner scanner, ArrayList<Integer> errorLines, int line) { | |||
| String input = scanner.nextLine(); | |||
| String[] parameters = input.split(" \\| "); | |||
|
|
|||
| if(parameters.length != Transaction.NUMBER_OF_PARAMETERS){ | |||
| @@ -109,9 +112,11 @@ public void addTransactionWithParameters(String[] parameters , ArrayList<Integer | |||
| try { | |||
|
|
|||
| String transactionId = parameters[0]; | |||
| if(!Transaction.isValidTxId(transactionId)){ | |||
|
|
|||
| if(!Transaction.isValidTxId(transactionId) || FileHandler.containEmptyParameter(parameters)){ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve error handling