Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch defense #35

Merged
merged 14 commits into from
Oct 12, 2024
Merged

Branch defense #35

merged 14 commits into from
Oct 12, 2024

Conversation

ZiliaAJY
Copy link
Collaborator

@ZiliaAJY ZiliaAJY commented Oct 12, 2024 •
edited
Loading

Add assertions, logging and BudgetBuddyExpense to handle all exceptions.

Fixes #36

ZiliaAJY added 13 commits October 12, 2024 19:53
@ZiliaAJY
Enable assertions in build.gradle file
db0e153
@ZiliaAJY
Add assertions to ensure budget amounts are valid
4484008
@ZiliaAJY
Fix numberOfBudgets not updated after loading from Storage
5075670
@ZiliaAJY
Add assertions and logging to ensure budgets are valid
d737eef
@ZiliaAJY
Add assertions, logging, and input validation for AddBudgetCommand
506f934
@ZiliaAJY
Add assertions and logging for DeductBudgetCommand
65eb5d9
@ZiliaAJY
Add assertions, logging, and throw exceptions for AddBudgetValidator
5d8285d
@ZiliaAJY
Add BudgetBudgetException to handle exception
892e5ef 
- Implemented try-catch blocks in BudgetBuddy.java
@ZiliaAJY
Add assertions, logging and throw exceptions for DeductBudgetValidator
cdbf79e
@ZiliaAJY
Use BudgetBuddyException for all exception handling
f148e75
@ZiliaAJY
Update EXPECTED.TXT with new output values
3e2d6ce
@ZiliaAJY
Resolve merge conflict in upstream/master and branch-defense
80f0d71
@ZiliaAJY
Change logger to static
7663150
@ZiliaAJY ZiliaAJY self-assigned this Oct 12, 2024
@ZiliaAJY ZiliaAJY added this to the v1.0 milestone Oct 12, 2024
@ZiliaAJY ZiliaAJY marked this pull request as ready for review October 12, 2024 15:03
@ZiliaAJY ZiliaAJY merged commit 3042968 into AY2425S1-CS2113-W10-1:master Oct 12, 2024
3 checks passed
@ZiliaAJY ZiliaAJY added the type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ZiliaAJY ZiliaAJY

Labels
type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Add assertions, exceptions and logging for Budget-related classes
1 participant
@ZiliaAJY