feat: ability for safe deployment of AGW from any address even if it …

…is not deployer or initial k1 owner (#4) * add ability for safe deployment from any address that is not deployer or initial k1 owner * tests
Abstract-Foundation · Dec 23, 2024 · 6a5642f · 6a5642f
1 parent 52742cf
commit 6a5642f
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 10 deletions.
diff --git a/contracts/AGWAccount.sol b/contracts/AGWAccount.sol
@@ -48,10 +48,13 @@ contract AGWAccount is
 
     uint256 public constant VERSION = 1;
 
+    address public immutable KNOWN_TRUSTED_EOA_VALIDATOR;
+
     /**
      * @notice Constructor for the account implementation
      */
-    constructor() {
+    constructor(address knownTrustedEoaValidator) {
+        KNOWN_TRUSTED_EOA_VALIDATOR = knownTrustedEoaValidator;
         _disableInitializers();
     }
 
@@ -76,14 +79,19 @@ contract AGWAccount is
         if (address(this) != expectedAddress) {
             revert Errors.INVALID_SALT();
         }
+
+        // add the initial k1 owner as an owner
+        _k1AddOwner(initialK1Owner);
+
         address thisDeployer = factory.accountToDeployer(address(this));
         if (thisDeployer != factory.deployer()) {
             if (initialK1Owner != thisDeployer) {
-                revert Errors.NOT_FROM_DEPLOYER();
+                // disregard any modules and initial call as the deployer is untrusted
+                _k1AddValidator(KNOWN_TRUSTED_EOA_VALIDATOR);
+                return;
             }
         }
 
-        _k1AddOwner(initialK1Owner);
         _k1AddValidator(initialK1Validator);
 
         for (uint256 i = 0; i < modules.length; ) {

diff --git a/deploy/deploy.ts b/deploy/deploy.ts
@@ -40,7 +40,7 @@ export default async function (): Promise<void> {
     implementation = await deployContract(
         hre,
         'ClaveImplementation',
-        [await batchCaller.getAddress()],
+        [await eoaValidator.getAddress()],
         {
             wallet: fundingWallet,
             silent: false,

diff --git a/test/utils/deployer.ts b/test/utils/deployer.ts
@@ -40,11 +40,11 @@ export class ClaveDeployer {
         );
     }
 
-    public async implementation(): Promise<Contract> {
+    public async implementation(eoaValidator: string): Promise<Contract> {
         return await deployContract(
             this.hre,
             CONTRACT_NAMES.IMPLEMENTATION,
-            [],
+            [eoaValidator],
             {
                 wallet: this.deployerWallet,
                 silent: true,
@@ -95,13 +95,13 @@ export class ClaveDeployer {
         return factory;
     }
 
-    public async setupFactory(): Promise<{
+    public async setupFactory(eoaValidator: string): Promise<{
         registry: Contract;
         implementation: Contract;
         factory: Contract;
     }> {
         const registry = await this.registry();
-        const implementation = await this.implementation();
+        const implementation = await this.implementation(eoaValidator);
         const factory = await this.factory(implementation, registry);
 
         return { registry, implementation, factory };

diff --git a/test/utils/fixture.ts b/test/utils/fixture.ts
@@ -31,9 +31,9 @@ export const fixture = async (
     const wallet = HDNodeWallet.createRandom();
 
     const registry = await deployer.registry();
-    const implementation = await deployer.implementation();
-    const factory = await deployer.factory(implementation, registry);
     const eoaValidator = await deployer.validator(VALIDATORS.EOA);
+    const implementation = await deployer.implementation(await eoaValidator.getAddress());
+    const factory = await deployer.factory(implementation, registry);
     const teeValidator = await deployer.validator(VALIDATORS.TEE);
     const mockValidator = await deployer.validator(VALIDATORS.MOCK);
     const passkeyValidator = await deployer.validator(VALIDATORS.PASSKEY);