Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: track deployed account by salt; make deployers a mapping #10

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

coffeexcoin
Copy link
Contributor

@coffeexcoin coffeexcoin commented Jan 6, 2025

PR-Codex overview

This PR focuses on enhancing the authorization mechanism for deployers in the AccountFactory and related contracts, improving security by ensuring only authorized deployers can perform certain actions.

Detailed summary

  • Updated checks for deployer authorization in AGWAccount.sol and AAFactoryPaymaster.sol.
  • Added authorizedDeployers mapping to AccountFactory for managing deployer permissions.
  • Changed event from DeployerChanged to DeployerAuthorized.
  • Modified setDeployer function to allow setting deployer authorization.
  • Enhanced getAddressForSalt to check if the account is already deployed.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@coffeexcoin coffeexcoin requested review from cygaar and 0xBeans January 6, 2025 13:47
@coffeexcoin coffeexcoin merged commit b64f621 into main Jan 6, 2025
1 check passed
@coffeexcoin coffeexcoin deleted the track-created branch January 7, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants