revert if account is already created for salt #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the
AccountFactory
contract by adding a check to prevent the deployment of accounts with the samesalt
and improving error handling for invalid initializers.Detailed summary
AccountFactory.sol
to revert if an account with the samesalt
already exists.Errors.sol
to include a new errorALREADY_CREATED()
.deployer.test.ts
to includesalt
when deploying accounts and check forINVALID_INITIALIZER
errors.