Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert if account is already created for salt #12

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

coffeexcoin
Copy link
Contributor

@coffeexcoin coffeexcoin commented Jan 7, 2025

PR-Codex overview

This PR focuses on enhancing the AccountFactory contract by adding a check to prevent the deployment of accounts with the same salt and improving error handling for invalid initializers.

Detailed summary

  • Added a check in AccountFactory.sol to revert if an account with the same salt already exists.
  • Updated the error handling in Errors.sol to include a new error ALREADY_CREATED().
  • Modified tests in deployer.test.ts to include salt when deploying accounts and check for INVALID_INITIALIZER errors.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@coffeexcoin coffeexcoin requested a review from cygaar January 7, 2025 03:58
@coffeexcoin coffeexcoin merged commit 82f48c7 into main Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant