Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dd-trace import #130

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix dd-trace import #130

merged 2 commits into from
Oct 30, 2023

Conversation

shunjizhan
Copy link
Contributor

reverted temp fix commit, and uses latest eth-provider which comes with dd-trace

@shunjizhan shunjizhan requested a review from xlc October 30, 2023 08:26
@shunjizhan shunjizhan marked this pull request as ready for review October 30, 2023 08:26
@shunjizhan
Copy link
Contributor Author

shunjizhan commented Oct 30, 2023 •
edited
Loading

The tests seem to be a little flaky? Ran the tests twice and the result seem to be different

@xlc
Copy link
Member

xlc commented Oct 30, 2023

Yeah it is based on latest block so some values like fees could be different.

@xlc
Copy link
Member

xlc commented Oct 30, 2023

https://github.com/AcalaNetwork/e2e-tests/actions/workflows/update.yml can be used to update the snapshots

@xlc xlc merged commit 799bdb4 into master Oct 30, 2023
3 of 4 checks passed
@xlc xlc deleted the fix-dd-trace-import branch October 30, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shunjizhan @xlc