Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add picker_display_callback #142

Closed

Conversation

dfeeley
Copy link
Contributor

@dfeeley dfeeley commented Jan 19, 2025

See #117.

Adds a setting for a picker_display_callback function, which if set will be run against items before displayed in the picker to allow the user to customize what gets shown. Inspired by the use case of trimming leading whitespace but to give end user flexibility to make whatever updates they may wish.

@AckslD
Copy link
Owner

AckslD commented Jan 25, 2025

Thanks for this! I'm happy to merge or leave for now until there's anyone wanting it as you said you couldn't see any usecase for it. What would you prefer?

@dfeeley
Copy link
Contributor Author

dfeeley commented Jan 25, 2025

Hello,
I think I would suggest leave it unmerged unless/until someone asks for the feature. No need to add more options / complexity that may not get used.
thanks

@AckslD
Copy link
Owner

AckslD commented Jan 26, 2025

Sounds good, will close this PR for now. Feel free to reopen or anyone else comment if they would want to have this.

@AckslD AckslD closed this Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants