Added Extensibility to support frameworks like bootstrap. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding some extra settings:
'dropdownLinkClass': 'atcb-link',
'dropdownLinkAttrs': [], // { key: 'data-toggle', value: 'dropdown' }
'dropdownMenuClass': 'atcb-list',
'dropdownMenuType': 'ul', // ul, div
'dropdownMenuItemClass': 'atcb-item',
'dropdownMenuItemType': 'li', // li, div, none
'dropdownMenuItemLinkClass': 'atcb-item-link',
Added some more properties to make it easier to reformat the dropdown.
// Added extensibility for bootstrap support.
'dropdownLinkClass': 'atcb-link', // btn btn-secondary dropdown-toggle
'dropdownLinkAttrs': [], // { key: 'data-toggle', value: 'dropdown' }
'dropdownMenuClass': 'atcb-list', // dropdown-menu
'dropdownMenuType': 'ul', // ul, div
'dropdownMenuItemClass': '',
'dropdownMenuItemType': 'li', // li, div, none
'dropdownMenuItemLinkClass': 'atcb-item-link', // dropdown-item
|
Thank you @MickeyElliott! We'll review the code this week as soon as possible! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few settings to enable the css class changing and html element tweeks. This let's me add this as a properly formatted bootstrap dropdown menu.
Sorry for the multiple commits. This is my first fork.