Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scmi 112253 no coordinates in bundle show results #384

Merged
merged 5 commits into from
Jan 10, 2024

Conversation

artjimlop
Copy link
Collaborator

ISSUE

I missed a really important point in my last PR. This default location is only needed when permissions aren't granted. Else, it's not necessary because we are going to retrieve the location we are at.

currentLocation?.longitude = 0.0
setCurrentPositionLocation()
isLocationInformedFromBundle = true
if (ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer you to use "PermissionUtils" class instead of calling for permissions directly. Example:

if (PermissionUtils.isLocationPermissionGranted(applicationContext)) {

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification! :D

@artjimlop artjimlop requested a review from ferranpons January 10, 2024 11:23
@ferranpons ferranpons merged commit c9d758b into master Jan 10, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the SCMI-112253-no-coordinates-in-bundle-show-results branch January 10, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants