Update redis-service-configuration, add clarification note regarding ece-tools and port. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ece-tools and port. When Platform Team (P.sh) add new redis-session service to an environment, they are not able to guarantee the port where redis-session is listening will be the same for all environments in a project. If we "hardcode" the redis-session port in the '.magento.env.yaml' config file we could provoque an error in some other environments of the project, if the redis-session service is not listening at that port. In this "Note", we clarify that only is needed to add the "redis.port" configuration section, if "ece-tools" are not able to get the port from RELATIONSHIPS services info environment variable (provided by Platform Team into the systems).
perezalo
commented
Dec 2, 2024
danidelcar
approved these changes
Dec 2, 2024
help/implementation-playbook/best-practices/planning/redis-service-configuration.md
Show resolved
Hide resolved
help/implementation-playbook/best-practices/planning/redis-service-configuration.md
Outdated
Show resolved
Hide resolved
help/implementation-playbook/best-practices/planning/redis-service-configuration.md
Outdated
Show resolved
Hide resolved
danidelcar
added
the
editorial
…vice-configuration.md New improved version. Co-authored-by: Daniel Del Carmen <[email protected]>
jeff-matthews
approved these changes
Dec 2, 2024
…vice-configuration.md Fix NOTE syntax. Co-authored-by: Daniel Del Carmen <[email protected]>
…vice-configuration.md Add new improved version of this NOTE Co-authored-by: Daniel Del Carmen <[email protected]>
|
Ok, in the end... we have the right NOTE :-D |
|
Following your advice... I have "migrated" this PR to the internal Git repos (in Git Corp): Best, Note: we could close this none. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Platform Team (P.sh) add new redis-session service to an environment, they are not able to guarantee the port where redis-session is listening will be the same for all environments in a project. If we "hardcode" the redis-session port in the '.magento.env.yaml' config file we could provoque an error in some other environments of the project, if the redis-session service is not listening at that port. In this "Note", we clarify that only is needed to add the "redis.port" configuration section, if "ece-tools" are not able to get the port from RELATIONSHIPS services info environment variable (provided by Platform Team into the systems).
Purpose of this pull request
This pull request (PR) is for adding a clarification NOTE into the Doc.
Affected pages
If you are fixing a GitHub issue, using the GitHub keyword format (https://help.github.com/en/articles/closing-issues-using-keywords#closing-an-issue-in-a-different-repository) closes the issue when this pull request is merged. Example:
Fixes #1234.mainis the default branch. Merged pull requests tomaingo live on the site automatically. Any requested changes to content on themainbranch must be related to the released codebase. Any content related to future releases goes in thedevelopbranch.See Contribution guidelines (https://github.com/AdobeDocs/commerce-operations.en/blob/main/contributing.md) for more information.
-->