-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a linter to validate external links #215
Conversation
@jeff-matthews please see a report and fix the links. |
Will do @dshevtsov. I'll push directly to this branch unless you say otherwise. Also, just an FYI that when I run
I don't know why, but maybe adding the |
Commit d8da865 reduced the warning count from 58 to 19. The output also matches my local test run after adding the All but two of the remaining 19 are located in MRG files, which I'm reluctant to fix since the source comes from READMEs in code base repos. Fixing them here will only be temporary. The test will start failing again when we regenerate the MRG files from source unless we fix the links in the source READMEs. @dshevtsov, how do you want to proceed for MRG files? |
I cannot reproduce the issue with As a project owner you are good to go for any changes in the config that work for you. Any changes to MRG have to be ported to the codebase. |
I noticed that running the test with and without VPN returns different results. It appears that when I run the test without VPN, my Internet provider blocks the excessive outgoing connections. |
I re-ran the this job because the symfony site was just running slow and the links finally resolved. Test results confirm. Only 17 warnings left to resolve (MRG topics). |
Local testing is inconsistent with the latest validation run. Local testing produces no warnings, but latest validation run produces two warnings. I suspect it has something to do with caching as mentioned in the plugin README:
I'm not sure where the cache lives though. Maybe somewhere in the Anyway, I'll fix the two remaining warnings and hopefully the validation run will pass. |
Purpose of this pull request
This pull request (PR):
Internal ticket: COMDOX-156
Test
Failed validate job reporting about dead links.