Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ItemsV2 to tutorial #391

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Adding ItemsV2 to tutorial #391

merged 4 commits into from
Jan 14, 2025

Conversation

jhadobe
Copy link
Contributor

@jhadobe jhadobe commented Jan 14, 2025

This PR updates this tutorial page to include itemsV2. It also changes the example product to one found in the current Venia catalog.

@jhadobe jhadobe added the editorial Typo and grammar fixes or minor rewrites to correct inaccuracies label Jan 14, 2025
@jhadobe jhadobe self-assigned this Jan 14, 2025
@jhadobe jhadobe requested a review from keharper January 14, 2025 15:45
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the changes to the product name and SKU. The tutorial is based on Luma, not Venia. Also, the VDL01 SKU is a downloadable product and shouldn't work here without a link ID.

@jhadobe jhadobe requested a review from keharper January 14, 2025 17:24
@jhadobe jhadobe merged commit 4c4a784 into main Jan 14, 2025
18 checks passed
@jhadobe jhadobe deleted the jh_itemsV2 branch January 14, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants