Vue 3 Sample #57
Merged
Vue 3 Sample #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pklaschka
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
Preface: I'm not familiar enough with Vue to do a proper code review of the Vue-specific parts of this PR. I'll, therefore, review it from a "plain" JS POV and do a functional test. If it works, I'll trust @JeffWinder about the Vue-specific aspects of the PR.
Code Review
uxpis expected within scripts defined in thepackage.json, but the Dev Tools CLI isn't listed as development dependency => was already the case for previous samples. I'll open an issue, but don't see this as part of this PR's scope.
No further comments
Functional test
Steps performed:
- Downloaded the sample
- As per the
README.md(using thenpm-based instructions): rannpm install - As per the
README.md(using thenpm-based instructions): rannpm run build=> success - Added plugin in UDT using
dist/manifest.json - Loaded the plugin
Plugin loaded successfully, everything appears to be working => functional test successfully completed 🙂
In conclusion
As far as I can tell, this PR looks good. Waiting for @amandahuarng to review and after that, I think we can merge this. Thanks for your contribution
|
The dependency comment is now tracked in #59 => officially out of scope for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample of UXP with Vue 3, based off the Vue 2 sample.