Google Pay improvements #1853
Merged
Google Pay improvements #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmengelt
reviewed
Oct 29, 2024
googlepay/src/main/java/com/adyen/checkout/googlepay/GooglePayComponent.kt
Outdated
Show resolved
Hide resolved
jreij
reviewed
Oct 29, 2024
OscarSpruit
force-pushed
the
feature/google-pay
branch
2 times, most recently
from
d47c46a to
b47ba4f
Compare
OscarSpruit
force-pushed
the
feature/google-pay
branch
3 times, most recently
from
4ffbf7f to
6011a6d
Compare
googlepay/src/main/java/com/adyen/checkout/googlepay/internal/ui/DefaultGooglePayDelegate.kt
Show resolved
Hide resolved
araratthehero
previously approved these changes
Nov 22, 2024
jreij
previously requested changes
Nov 22, 2024
OscarSpruit
force-pushed
the
feature/google-pay
branch
2 times, most recently
from
aa68232 to
fd29e5b
Compare
jreij
reviewed
Dec 10, 2024
jreij
requested changes
Dec 10, 2024
jreij
reviewed
Dec 11, 2024
OscarSpruit
force-pushed
the
feature/google-pay
branch
from
57eb6cc to
98c5b9c
Compare
COAND-855
COAND-855
COAND-855
COAND-855
COAND-855
COAND-855
COAND-1012
COAND-1012
COAND-1012
COAND-1012
COAND-1012
COAND-941
This will allow to have customized states. The drawable will now also use it's original color. COAND-943
Exception flow didn't work as the value was only received by one observer. COAND-943
COAND-943
COAND-941
COAND-944
Previously, the GooglePayView was replaced with ProcessingPaymentView. This causes the Activity Result API to fail and not deliver the result in case the view got recreated on configuration change. By keeping the GooglePayView in view it will be able to successfully restore it's state and deliver the activity result. Making the loading state part of the GooglePayView is essential to fix this problem. COAND-941
Before it was based on if the button was shown or not, which can be hidden even if the component state is fully valid and ready. COAND-941
COAND-1009
COAND-1009
COAND-1009
OscarSpruit
force-pushed
the
feature/google-pay
branch
from
98c5b9c to
c73b4de
Compare
✅ No public API changes |
|
jreij
approved these changes
Dec 12, 2024
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a huge compilation of smaller PRs. These small PRs have all been reviewed.
Checklist
COAND-941