Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State management changes - MBway #1975

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

araratthehero
Copy link
Contributor

Description

  • Move state outside of views

Checklist

  • If applicable, make sure Breaking change label is added.
  • Code is unit tested
  • Changes are tested manually
  • Related issues are linked

COAND-935

Create FieldValidator to validate fields in the Delegate side

COAND-935
Add field focus changed events and update view state

COAND-935
…ges, regardless the focus state. This happens when the Submit button is clicked.

COAND-935
…sure that the error message does not hid

COAND-935
… for validation and data manipulation

COAND-935
…ldId will cause a compile time error

COAND-935
COAND-935
Copy link

🚫 Public API changes

ui-core

@@ -217,13 +217,6 @@ public final class com/adyen/checkout/ui/core/internal/ui/model/AddressParams$Po
public fun toString ()Ljava/lang/String;
}

-public final class com/adyen/checkout/ui/core/internal/ui/model/SubmitHandlerEvent$InvalidInput : com/adyen/checkout/ui/core/internal/ui/model/SubmitHandlerEvent {
-	public static final field INSTANCE Lcom/adyen/checkout/ui/core/internal/ui/model/SubmitHandlerEvent$InvalidInput;
-	public fun equals (Ljava/lang/Object;)Z
-	public fun hashCode ()I
-	public fun toString ()Ljava/lang/String;
-}
-
public final class com/adyen/checkout/ui/core/internal/ui/view/AddressFormInput : android/widget/LinearLayout {
public fun <init> (Landroid/content/Context;)V
public fun <init> (Landroid/content/Context;Landroid/util/AttributeSet;)V

If these changes are intentional run ./gradlew apiDump and commit the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant