-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State management changes - MBway #1975
Draft
araratthehero
wants to merge
16
commits into
main
Choose a base branch
from
refactor/improve_state_handling_for_views_mbway
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
State management changes - MBway #1975
araratthehero
wants to merge
16
commits into
main
from
refactor/improve_state_handling_for_views_mbway
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COAND-935
Create FieldValidator to validate fields in the Delegate side COAND-935
Add field focus changed events and update view state COAND-935
…icked and the input is not valid COAND-935
…ing it manually COAND-935
…ges, regardless the focus state. This happens when the Submit button is clicked. COAND-935
COAND-935
…sure that the error message does not hid COAND-935
… for validation and data manipulation COAND-935
…ldId will cause a compile time error COAND-935
🚫 Public API changesui-core@@ -217,13 +217,6 @@ public final class com/adyen/checkout/ui/core/internal/ui/model/AddressParams$Po
public fun toString ()Ljava/lang/String;
}
-public final class com/adyen/checkout/ui/core/internal/ui/model/SubmitHandlerEvent$InvalidInput : com/adyen/checkout/ui/core/internal/ui/model/SubmitHandlerEvent {
- public static final field INSTANCE Lcom/adyen/checkout/ui/core/internal/ui/model/SubmitHandlerEvent$InvalidInput;
- public fun equals (Ljava/lang/Object;)Z
- public fun hashCode ()I
- public fun toString ()Ljava/lang/String;
-}
-
public final class com/adyen/checkout/ui/core/internal/ui/view/AddressFormInput : android/widget/LinearLayout {
public fun <init> (Landroid/content/Context;)V
public fun <init> (Landroid/content/Context;Landroid/util/AttributeSet;)V If these changes are intentional run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
COAND-935