Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Client.php #716

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Update Client.php #716

merged 2 commits into from
Dec 9, 2024

Conversation

seahshaocheng
Copy link
Contributor

@seahshaocheng seahshaocheng commented Dec 4, 2024

Hi team,

My name is Mark Seah, I am an implementation manager in Adyen based in Singapore. Reach out to me in our internal chat application, if there is any clarification needed.

Including APSE LIVE ENDPOINT constant for cloud terminal integration as per Adyen documentation. Some of our APAC merchants use this library and need
https://docs.adyen.com/point-of-sale/design-your-integration/terminal-api/#live-endpoints

Include APSE LIVE ENDPOINT for cloud terminal integration as per Adyen documentation.

https://docs.adyen.com/point-of-sale/design-your-integration/terminal-api/#live-endpoints
@seahshaocheng seahshaocheng requested a review from a team as a code owner December 4, 2024 06:15
@Kwok-he-Chu Kwok-he-Chu self-requested a review December 4, 2024 09:15
@Kwok-he-Chu
Copy link

Kwok-he-Chu commented Dec 4, 2024

@seahshaocheng Hi Seah, thanks for the contribution!

Can you update the region & mappings for APSE here as well: https://github.com/Adyen/adyen-php-api-library/blob/main/src/Adyen/Region.php#L22

Edit: These mappings are used in the Client when instantiating the PosPayment: https://github.com/Adyen/adyen-php-api-library/blob/main/src/Adyen/Service/PosPayment.php#L42

include APSE constant in region
@seahshaocheng
Copy link
Contributor Author

Copy link

sonarqubecloud bot commented Dec 5, 2024

@DjoykeAbyah DjoykeAbyah merged commit 5b5a72e into Adyen:main Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants