Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added APSE to VALID_REGIONS #717

Merged
merged 4 commits into from
Dec 10, 2024
Merged

added APSE to VALID_REGIONS #717

merged 4 commits into from
Dec 10, 2024

Conversation

DjoykeAbyah
Copy link
Member

Added APSE to valid regions since we have a live endpoint added to TERMINAL_API_ENDPOINTS_MAPPING

@DjoykeAbyah DjoykeAbyah requested a review from a team as a code owner December 9, 2024 12:46
@Kwok-he-Chu Kwok-he-Chu self-requested a review December 9, 2024 16:01
Kwok-he-Chu
Kwok-he-Chu requested changes Dec 9, 2024
View reviewed changes
Copy link

@Kwok-he-Chu Kwok-he-Chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the tests that allow us to spot these changes from now on if we decide to modify it:

  • Test for the VALID_REGIONS
  • Test for each TERMINAL_API_ENDPOINTS_MAPPING (and whether they are mapping correctly

@DjoykeAbyah
Copy link
Member Author

@Kwok-he-Chu, I've included the unit test. Since India is also part of valid regions I've included the url in Client.php and added it to the mapping.

ayodejidev
ayodejidev previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ayodejidev ayodejidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DjoykeAbyah
adjusted test to asser region and mapping seperately, removed client …
e7d7291 
…in terminal endpoint from client.php and region.php mapping
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DjoykeAbyah DjoykeAbyah merged commit a573952 into main Dec 10, 2024
4 checks passed
@DjoykeAbyah DjoykeAbyah deleted the add-APSE-to-valid-regions branch December 10, 2024 11:49
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwok-he-Chu Kwok-he-Chu Kwok-he-Chu requested changes

@ayodejidev ayodejidev ayodejidev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DjoykeAbyah @ayodejidev @Kwok-he-Chu