Update charon #407
Merged
Update charon #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
commented
Jan 2, 2025
| let f = trans.f in | ||
| let explicit_info = | ||
| explicit_info_drop_prefix decl.generics f.signature.explicit_info | ||
| in | ||
| (* TODO: this is likely incorrect, we should instantiate the binders properly *) |
There was a problem hiding this comment.
@sonmarcho This will likely cause issues after AeneasVerif/charon#127: the full method generics will no longer be a simple concatenation of the impl generics + method generics (because I'll be adding the extra associated type parameters at the end of the list of parameters instead of in the middle). We should find a way to instantiate the binders properly here.
Nadrieril
commented
Jan 2, 2025
| @@ -728,6 +724,7 @@ let eval_transparent_function_call_symbolic_inst (span : Meta.span) | |||
| we also need to update the generics. | |||
| *) | |||
| let func = FunId fid in | |||
| (* TODO: the `trait_method_generics` look fishy *) | |||
There was a problem hiding this comment.
@sonmarcho What are the trait_method_generics supposed to correspond to? From the name I'd expect these would be the generics just for the method, but here you pass generics valid for the function item (which include impl generics).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to AeneasVerif/charon#512.