-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/2.8.120 #75
base: feature/2.8.120
Are you sure you want to change the base?
Dev/2.8.120 #75
Conversation
@@ -77,6 +94,8 @@ dependencies { | |||
implementation 'com.pierfrancescosoffritti.androidyoutubeplayer:custom-ui:12.0.0' | |||
implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1" | |||
implementation "androidx.lifecycle:lifecycle-livedata-ktx:2.5.1" | |||
|
|||
implementation 'com.google.protobuf:protobuf-javalite:3.21.12' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protobuf 不需要重复引用,底层core已经依赖了,可以直接使用
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
底层并没有依赖,无法使用
*/ | ||
private val widgetActiveObserver = object : AgoraWidgetActiveObserver { | ||
override fun onWidgetActive(widgetId: String) { | ||
if (widget == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
widget一直没有赋值操作
override fun onWidgetInActive(widgetId: String) { | ||
if (widget != null) { | ||
ContextCompat.getMainExecutor(binding.root.context).execute { | ||
widget!!.release() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不建议使用!!,容易崩
} | ||
} | ||
|
||
override fun getItemCount() = 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 抽成const,注释一下
} | ||
|
||
R.layout.fcr_online_rtt_setting_dialog_content_list -> { | ||
if (position == 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
position 1 2 3定义成常量,注释
No description provided.