Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/2.8.120 #75

Open
wants to merge 12 commits into
base: feature/2.8.120
Choose a base branch
from

Conversation

Loren-Wang
Copy link

No description provided.

@@ -77,6 +94,8 @@ dependencies {
implementation 'com.pierfrancescosoffritti.androidyoutubeplayer:custom-ui:12.0.0'
implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1"
implementation "androidx.lifecycle:lifecycle-livedata-ktx:2.5.1"

implementation 'com.google.protobuf:protobuf-javalite:3.21.12'
Copy link
Collaborator

@fenggit fenggit Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protobuf 不需要重复引用,底层core已经依赖了,可以直接使用

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

底层并没有依赖,无法使用

*/
private val widgetActiveObserver = object : AgoraWidgetActiveObserver {
override fun onWidgetActive(widgetId: String) {
if (widget == null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

widget一直没有赋值操作

override fun onWidgetInActive(widgetId: String) {
if (widget != null) {
ContextCompat.getMainExecutor(binding.root.context).execute {
widget!!.release()
Copy link
Collaborator

@fenggit fenggit Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不建议使用!!,容易崩

}
}

override fun getItemCount() = 5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 抽成const,注释一下

}

R.layout.fcr_online_rtt_setting_dialog_content_list -> {
if (position == 1) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

position 1 2 3定义成常量,注释

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants