Skip to content

Commit

Permalink
build: Downgrade execa to 9.1.0 for Node.js 18.18 support (#10500)
Browse files Browse the repository at this point in the history
## Description
Version ^18.19.0 is required by execa 9.5.1 (which we already use in fast-usdc and a3p-integration/proposals/n:upgrade-next): https://github.com/Agoric/agoric-sdk/actions/runs/11863279067/job/33064414447?pr=10499#step:4:270
```console
error [email protected]: The engine "node" is incompatible with this module. Expected version "^18.19.0 || >=20.5.0". Got "18.18.2"
```
...and is the LTS version anyway.

### Security Considerations
n/a

### Scaling Considerations
n/a

### Documentation Considerations
n/a

### Testing Considerations
There was a comment from last year about Node.js v18.19 incompatibility; integration testing will reveal if it has in fact been resolved.

### Upgrade Considerations
It might be time to bump the Node.js ^18.12 [prerequisite](https://github.com/Agoric/agoric-sdk/tree/master#prerequisites).
  • Loading branch information
gibson042 authored Nov 16, 2024
1 parent ef0668a commit 76ad0fc
Show file tree
Hide file tree
Showing 10 changed files with 134 additions and 59 deletions.
2 changes: 1 addition & 1 deletion a3p-integration/proposals/n:upgrade-next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@endo/marshal": "^1.6.1",
"ava": "^5.3.1",
"better-sqlite3": "^9.6.0",
"execa": "^9.5.1"
"execa": "9.1.0"
},
"ava": {
"concurrency": 1,
Expand Down
38 changes: 27 additions & 11 deletions a3p-integration/proposals/n:upgrade-next/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -872,29 +872,29 @@ __metadata:
languageName: node
linkType: hard

"execa@npm:^9.3.1":
version: 9.4.0
resolution: "execa@npm:9.4.0"
"execa@npm:9.1.0":
version: 9.1.0
resolution: "execa@npm:9.1.0"
dependencies:
"@sindresorhus/merge-streams": "npm:^4.0.0"
cross-spawn: "npm:^7.0.3"
figures: "npm:^6.1.0"
get-stream: "npm:^9.0.0"
human-signals: "npm:^8.0.0"
human-signals: "npm:^7.0.0"
is-plain-obj: "npm:^4.1.0"
is-stream: "npm:^4.0.1"
npm-run-path: "npm:^6.0.0"
npm-run-path: "npm:^5.2.0"
pretty-ms: "npm:^9.0.0"
signal-exit: "npm:^4.1.0"
strip-final-newline: "npm:^4.0.0"
yoctocolors: "npm:^2.0.0"
checksum: 10c0/6ad06c627b5d7bb007bc7b6cc35d7e32b5a3365375ffc8ddbcc12d2423651fa9928ba0c447cc9e60079e505e9b24fbe0a57f80371511d7d20302c04c2d3ce95e
checksum: 10c0/9a4810b93d098eb0bed48793b61c3aa3e5804867c2c5808cd2a597a6e71738151a74dc792909085ce1d38e89f4b0e078d93ffd165aaca2d9a6728f3616f8e5c0
languageName: node
linkType: hard

"execa@npm:^9.5.1":
version: 9.5.1
resolution: "execa@npm:9.5.1"
"execa@npm:^9.3.1":
version: 9.4.0
resolution: "execa@npm:9.4.0"
dependencies:
"@sindresorhus/merge-streams": "npm:^4.0.0"
cross-spawn: "npm:^7.0.3"
Expand All @@ -908,7 +908,7 @@ __metadata:
signal-exit: "npm:^4.1.0"
strip-final-newline: "npm:^4.0.0"
yoctocolors: "npm:^2.0.0"
checksum: 10c0/1a628d535c5a088f9e17a735bb3143efc4198095392b319ba877b2975d5c3c57724536dccb6f68f1cd9b3af331c5a9e8c1aeb338d52ab316b1e008ff453374a7
checksum: 10c0/6ad06c627b5d7bb007bc7b6cc35d7e32b5a3365375ffc8ddbcc12d2423651fa9928ba0c447cc9e60079e505e9b24fbe0a57f80371511d7d20302c04c2d3ce95e
languageName: node
linkType: hard

Expand Down Expand Up @@ -1158,6 +1158,13 @@ __metadata:
languageName: node
linkType: hard

"human-signals@npm:^7.0.0":
version: 7.0.0
resolution: "human-signals@npm:7.0.0"
checksum: 10c0/ce0c6d62d2e9bfe529d48f7c7fdf4b8c70fce950eef7850719b4e3f5bc71795ae7d61a3699ce13262bed7847705822601cc81f1921ea6a2906852e16228a94ab
languageName: node
linkType: hard

"human-signals@npm:^8.0.0":
version: 8.0.0
resolution: "human-signals@npm:8.0.0"
Expand Down Expand Up @@ -1716,6 +1723,15 @@ __metadata:
languageName: node
linkType: hard

"npm-run-path@npm:^5.2.0":
version: 5.3.0
resolution: "npm-run-path@npm:5.3.0"
dependencies:
path-key: "npm:^4.0.0"
checksum: 10c0/124df74820c40c2eb9a8612a254ea1d557ddfab1581c3e751f825e3e366d9f00b0d76a3c94ecd8398e7f3eee193018622677e95816e8491f0797b21e30b2deba
languageName: node
linkType: hard

"npm-run-path@npm:^6.0.0":
version: 6.0.0
resolution: "npm-run-path@npm:6.0.0"
Expand Down Expand Up @@ -2033,7 +2049,7 @@ __metadata:
"@endo/marshal": "npm:^1.6.1"
ava: "npm:^5.3.1"
better-sqlite3: "npm:^9.6.0"
execa: "npm:^9.5.1"
execa: "npm:9.1.0"
typescript: "npm:^5.6.3"
languageName: unknown
linkType: soft
Expand Down
2 changes: 1 addition & 1 deletion a3p-integration/proposals/p:upgrade-19/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@endo/marshal": "^1.5.4",
"ava": "^5.3.1",
"better-sqlite3": "^9.6.0",
"execa": "^9.3.1"
"execa": "9.1.0"
},
"ava": {
"concurrency": 1,
Expand Down
38 changes: 37 additions & 1 deletion a3p-integration/proposals/p:upgrade-19/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2409,6 +2409,26 @@ __metadata:
languageName: node
linkType: hard

"execa@npm:9.1.0":
version: 9.1.0
resolution: "execa@npm:9.1.0"
dependencies:
"@sindresorhus/merge-streams": "npm:^4.0.0"
cross-spawn: "npm:^7.0.3"
figures: "npm:^6.1.0"
get-stream: "npm:^9.0.0"
human-signals: "npm:^7.0.0"
is-plain-obj: "npm:^4.1.0"
is-stream: "npm:^4.0.1"
npm-run-path: "npm:^5.2.0"
pretty-ms: "npm:^9.0.0"
signal-exit: "npm:^4.1.0"
strip-final-newline: "npm:^4.0.0"
yoctocolors: "npm:^2.0.0"
checksum: 10c0/9a4810b93d098eb0bed48793b61c3aa3e5804867c2c5808cd2a597a6e71738151a74dc792909085ce1d38e89f4b0e078d93ffd165aaca2d9a6728f3616f8e5c0
languageName: node
linkType: hard

"execa@npm:^9.3.1":
version: 9.5.1
resolution: "execa@npm:9.5.1"
Expand Down Expand Up @@ -2817,6 +2837,13 @@ __metadata:
languageName: node
linkType: hard

"human-signals@npm:^7.0.0":
version: 7.0.0
resolution: "human-signals@npm:7.0.0"
checksum: 10c0/ce0c6d62d2e9bfe529d48f7c7fdf4b8c70fce950eef7850719b4e3f5bc71795ae7d61a3699ce13262bed7847705822601cc81f1921ea6a2906852e16228a94ab
languageName: node
linkType: hard

"human-signals@npm:^8.0.0":
version: 8.0.0
resolution: "human-signals@npm:8.0.0"
Expand Down Expand Up @@ -3566,6 +3593,15 @@ __metadata:
languageName: node
linkType: hard

"npm-run-path@npm:^5.2.0":
version: 5.3.0
resolution: "npm-run-path@npm:5.3.0"
dependencies:
path-key: "npm:^4.0.0"
checksum: 10c0/124df74820c40c2eb9a8612a254ea1d557ddfab1581c3e751f825e3e366d9f00b0d76a3c94ecd8398e7f3eee193018622677e95816e8491f0797b21e30b2deba
languageName: node
linkType: hard

"npm-run-path@npm:^6.0.0":
version: 6.0.0
resolution: "npm-run-path@npm:6.0.0"
Expand Down Expand Up @@ -4007,7 +4043,7 @@ __metadata:
"@endo/marshal": "npm:^1.5.4"
ava: "npm:^5.3.1"
better-sqlite3: "npm:^9.6.0"
execa: "npm:^9.3.1"
execa: "npm:9.1.0"
languageName: unknown
linkType: soft

Expand Down
2 changes: 1 addition & 1 deletion a3p-integration/proposals/z:acceptance/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@endo/marshal": "^1.5.3",
"agoric": "dev",
"ava": "^6.1.2",
"execa": "^9.3.1",
"execa": "9.1.0",
"tsx": "^4.17.0"
},
"$comment": "UNTIL https://github.com/Agoric/agoric-sdk/issues/10259",
Expand Down
38 changes: 37 additions & 1 deletion a3p-integration/proposals/z:acceptance/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2833,6 +2833,26 @@ __metadata:
languageName: node
linkType: hard

"execa@npm:9.1.0":
version: 9.1.0
resolution: "execa@npm:9.1.0"
dependencies:
"@sindresorhus/merge-streams": "npm:^4.0.0"
cross-spawn: "npm:^7.0.3"
figures: "npm:^6.1.0"
get-stream: "npm:^9.0.0"
human-signals: "npm:^7.0.0"
is-plain-obj: "npm:^4.1.0"
is-stream: "npm:^4.0.1"
npm-run-path: "npm:^5.2.0"
pretty-ms: "npm:^9.0.0"
signal-exit: "npm:^4.1.0"
strip-final-newline: "npm:^4.0.0"
yoctocolors: "npm:^2.0.0"
checksum: 10c0/9a4810b93d098eb0bed48793b61c3aa3e5804867c2c5808cd2a597a6e71738151a74dc792909085ce1d38e89f4b0e078d93ffd165aaca2d9a6728f3616f8e5c0
languageName: node
linkType: hard

"execa@npm:^9.3.1":
version: 9.5.1
resolution: "execa@npm:9.5.1"
Expand Down Expand Up @@ -3341,6 +3361,13 @@ __metadata:
languageName: node
linkType: hard

"human-signals@npm:^7.0.0":
version: 7.0.0
resolution: "human-signals@npm:7.0.0"
checksum: 10c0/ce0c6d62d2e9bfe529d48f7c7fdf4b8c70fce950eef7850719b4e3f5bc71795ae7d61a3699ce13262bed7847705822601cc81f1921ea6a2906852e16228a94ab
languageName: node
linkType: hard

"human-signals@npm:^8.0.0":
version: 8.0.0
resolution: "human-signals@npm:8.0.0"
Expand Down Expand Up @@ -4238,6 +4265,15 @@ __metadata:
languageName: node
linkType: hard

"npm-run-path@npm:^5.2.0":
version: 5.3.0
resolution: "npm-run-path@npm:5.3.0"
dependencies:
path-key: "npm:^4.0.0"
checksum: 10c0/124df74820c40c2eb9a8612a254ea1d557ddfab1581c3e751f825e3e366d9f00b0d76a3c94ecd8398e7f3eee193018622677e95816e8491f0797b21e30b2deba
languageName: node
linkType: hard

"npm-run-path@npm:^6.0.0":
version: 6.0.0
resolution: "npm-run-path@npm:6.0.0"
Expand Down Expand Up @@ -4747,7 +4783,7 @@ __metadata:
"@endo/marshal": "npm:^1.5.3"
agoric: "npm:dev"
ava: "npm:^6.1.2"
execa: "npm:^9.3.1"
execa: "npm:9.1.0"
tsx: "npm:^4.17.0"
typescript: "npm:^5.5.4"
languageName: unknown
Expand Down
2 changes: 1 addition & 1 deletion multichain-testing/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"ava": "^6.1.3",
"eslint": "^8.56.0",
"eslint-config-prettier": "^9.1.0",
"execa": "^9.2.0",
"execa": "9.1.0",
"fs-extra": "^11.2.0",
"patch-package": "^8.0.0",
"starshipjs": "2.4.1",
Expand Down
10 changes: 5 additions & 5 deletions multichain-testing/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2128,9 +2128,9 @@ __metadata:
languageName: node
linkType: hard

"execa@npm:^9.2.0":
version: 9.2.0
resolution: "execa@npm:9.2.0"
"execa@npm:9.1.0":
version: 9.1.0
resolution: "execa@npm:9.1.0"
dependencies:
"@sindresorhus/merge-streams": "npm:^4.0.0"
cross-spawn: "npm:^7.0.3"
Expand All @@ -2144,7 +2144,7 @@ __metadata:
signal-exit: "npm:^4.1.0"
strip-final-newline: "npm:^4.0.0"
yoctocolors: "npm:^2.0.0"
checksum: 10c0/339e69bd01bfdc032122ef18d412ccda4386c7752b864607c2e8683a1531b4aab436744aeacee548e1be239adb2b52888da64ffd761e7e22f56f8f14cf66e4a7
checksum: 10c0/9a4810b93d098eb0bed48793b61c3aa3e5804867c2c5808cd2a597a6e71738151a74dc792909085ce1d38e89f4b0e078d93ffd165aaca2d9a6728f3616f8e5c0
languageName: node
linkType: hard

Expand Down Expand Up @@ -3912,7 +3912,7 @@ __metadata:
ava: "npm:^6.1.3"
eslint: "npm:^8.56.0"
eslint-config-prettier: "npm:^9.1.0"
execa: "npm:^9.2.0"
execa: "npm:9.1.0"
fs-extra: "npm:^11.2.0"
patch-package: "npm:^8.0.0"
starshipjs: "npm:2.4.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/fast-usdc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@fast-check/ava": "^2.0.1",
"ava": "^5.3.0",
"c8": "^9.1.0",
"execa": "^9.5.1",
"execa": "9.1.0",
"ts-blank-space": "^0.4.1"
},
"dependencies": {
Expand Down
59 changes: 23 additions & 36 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6428,6 +6428,24 @@ eventemitter3@^4.0.0, eventemitter3@^4.0.4:
resolved "https://registry.yarnpkg.com/eventemitter3/-/eventemitter3-4.0.7.tgz#2de9b68f6528d5644ef5c59526a1b4a07306169f"
integrity sha512-8guHBZCwKnFhYdHr2ysuRWErTwhoN2X8XELRlrRwpmfeY2jjuUN4taQMsULKUVo1K4DvZl+0pgfyoysHxvmvEw==

[email protected]:
version "9.1.0"
resolved "https://registry.yarnpkg.com/execa/-/execa-9.1.0.tgz#c42845d2b079642b8e07d9de81db13cdb91e7a9b"
integrity sha512-lSgHc4Elo2m6bUDhc3Hl/VxvUDJdQWI40RZ4KMY9bKRc+hgMOT7II/JjbNDhI8VnMtrCb7U/fhpJIkLORZozWw==
dependencies:
"@sindresorhus/merge-streams" "^4.0.0"
cross-spawn "^7.0.3"
figures "^6.1.0"
get-stream "^9.0.0"
human-signals "^7.0.0"
is-plain-obj "^4.1.0"
is-stream "^4.0.1"
npm-run-path "^5.2.0"
pretty-ms "^9.0.0"
signal-exit "^4.1.0"
strip-final-newline "^4.0.0"
yoctocolors "^2.0.0"

execa@^5.0.0:
version "5.1.1"
resolved "https://registry.yarnpkg.com/execa/-/execa-5.1.1.tgz#f80ad9cbf4298f7bd1d4c9555c21e93741c411dd"
Expand Down Expand Up @@ -6458,24 +6476,6 @@ execa@^7.1.1:
signal-exit "^3.0.7"
strip-final-newline "^3.0.0"

execa@^9.5.1:
version "9.5.1"
resolved "https://registry.yarnpkg.com/execa/-/execa-9.5.1.tgz#ab9b68073245e1111bba359962a34fcdb28deef2"
integrity sha512-QY5PPtSonnGwhhHDNI7+3RvY285c7iuJFFB+lU+oEzMY/gEGJ808owqJsrr8Otd1E/x07po1LkUBmdAc5duPAg==
dependencies:
"@sindresorhus/merge-streams" "^4.0.0"
cross-spawn "^7.0.3"
figures "^6.1.0"
get-stream "^9.0.0"
human-signals "^8.0.0"
is-plain-obj "^4.1.0"
is-stream "^4.0.1"
npm-run-path "^6.0.0"
pretty-ms "^9.0.0"
signal-exit "^4.1.0"
strip-final-newline "^4.0.0"
yoctocolors "^2.0.0"

expand-template@^2.0.3:
version "2.0.3"
resolved "https://registry.yarnpkg.com/expand-template/-/expand-template-2.0.3.tgz#6e14b3fcee0f3a6340ecb57d2e8918692052a47c"
Expand Down Expand Up @@ -7424,10 +7424,10 @@ human-signals@^4.3.0:
resolved "https://registry.yarnpkg.com/human-signals/-/human-signals-4.3.1.tgz#ab7f811e851fca97ffbd2c1fe9a958964de321b2"
integrity sha512-nZXjEF2nbo7lIw3mgYjItAfgQXog3OjJogSbKa2CQIIvSGWcKgeJnQlNXip6NglNzYH45nSRiEVimMvYL8DDqQ==

human-signals@^8.0.0:
version "8.0.0"
resolved "https://registry.yarnpkg.com/human-signals/-/human-signals-8.0.0.tgz#2d3d63481c7c2319f0373428b01ffe30da6df852"
integrity sha512-/1/GPCpDUCCYwlERiYjxoczfP0zfvZMU/OWgQPMya9AbAE24vseigFdhAMObpc8Q4lc/kjutPfUddDYyAmejnA==
human-signals@^7.0.0:
version "7.0.0"
resolved "https://registry.yarnpkg.com/human-signals/-/human-signals-7.0.0.tgz#93e58e0c19cfec1dded4af10cd4969f5ab75f6c8"
integrity sha512-74kytxOUSvNbjrT9KisAbaTZ/eJwD/LrbM/kh5j0IhPuJzwuA19dWvniFGwBzN9rVjg+O/e+F310PjObDXS+9Q==

humanize-ms@^1.2.1:
version "1.2.1"
Expand Down Expand Up @@ -9660,21 +9660,13 @@ npm-run-path@^4.0.1:
dependencies:
path-key "^3.0.0"

npm-run-path@^5.1.0:
npm-run-path@^5.1.0, npm-run-path@^5.2.0:
version "5.3.0"
resolved "https://registry.yarnpkg.com/npm-run-path/-/npm-run-path-5.3.0.tgz#e23353d0ebb9317f174e93417e4a4d82d0249e9f"
integrity sha512-ppwTtiJZq0O/ai0z7yfudtBpWIoxM8yE6nHi1X47eFR2EWORqfbu6CnPlNsjeN683eT0qG6H/Pyf9fCcvjnnnQ==
dependencies:
path-key "^4.0.0"

npm-run-path@^6.0.0:
version "6.0.0"
resolved "https://registry.yarnpkg.com/npm-run-path/-/npm-run-path-6.0.0.tgz#25cfdc4eae04976f3349c0b1afc089052c362537"
integrity sha512-9qny7Z9DsQU8Ou39ERsPU4OZQlSTP47ShQzuKZ6PRXpYLtIFgl/DEBYEXKlvcEa+9tHVcK8CF81Y2V72qaZhWA==
dependencies:
path-key "^4.0.0"
unicorn-magic "^0.3.0"

npmlog@^6.0.0, npmlog@^6.0.2:
version "6.0.2"
resolved "https://registry.yarnpkg.com/npmlog/-/npmlog-6.0.2.tgz#c8166017a42f2dea92d6453168dd865186a70830"
Expand Down Expand Up @@ -12239,11 +12231,6 @@ unicode-property-aliases-ecmascript@^2.0.0:
resolved "https://registry.yarnpkg.com/unicode-property-aliases-ecmascript/-/unicode-property-aliases-ecmascript-2.1.0.tgz#43d41e3be698bd493ef911077c9b131f827e8ccd"
integrity sha512-6t3foTQI9qne+OZoVQB/8x8rk2k1eVy1gRXhV3oFQ5T6R1dqQ1xtin3XqSlx3+ATBkliTaR/hHyJBm+LVPNM8w==

unicorn-magic@^0.3.0:
version "0.3.0"
resolved "https://registry.yarnpkg.com/unicorn-magic/-/unicorn-magic-0.3.0.tgz#4efd45c85a69e0dd576d25532fbfa22aa5c8a104"
integrity sha512-+QBBXBCvifc56fsbuxZQ6Sic3wqqc3WWaqxs58gvJrcOuN83HGTCwz3oS5phzU9LthRNE9VrJCFCLUgHeeFnfA==

unique-filename@^2.0.0:
version "2.0.1"
resolved "https://registry.yarnpkg.com/unique-filename/-/unique-filename-2.0.1.tgz#e785f8675a9a7589e0ac77e0b5c34d2eaeac6da2"
Expand Down

0 comments on commit 76ad0fc

Please sign in to comment.