Clean up after smartWalllet incarnation2 repair #10319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
wallet
hygiene
Chris-Hibbert
force-pushed
the
9404-cleanup
branch
from
984b81e to
88019c5
Compare
Deploying agoric-sdk with
|
| Latest commit: |
88019c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://24691081.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9404-cleanup.agoric-sdk.pages.dev |
turadg
approved these changes
Oct 23, 2024
turadg
approved these changes
Oct 23, 2024
Chris-Hibbert
added
the
automerge:rebase
how so? I don't see anything relevant in |
|
It was there until 3 days ago. I'll have to add it again. |
mergify bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
refs: #9404 refs: #10336 refs: #10319 ## Description #10319 cleaned up some dead code in smartWallets, and expected the changes to be included in Upgrade 18, because the smartWallet proposal was included in `upgrade.go`. #10336 cleaned up proposals that were left over from Upgrade 17. This reinstates the upgrade for wallets. ### Security Considerations The cleaned up code is benign. it was designed to run once and has served its purpose. Removing it shouldn't affect anything. ### Scaling Considerations No scaling consequences. ### Documentation Considerations None ### Testing Considerations The wallet upgrade was included in A3P-integration testing until three days ago. #10319 has been tested since 5 days ago without incident. removing benign dead code doesn't require extra tests. ### Upgrade Considerations There is no *requirement* that this change be included in U18, so if it causes problems or gives anyone the willies, it can wait for the next release, but it's ready now.
mujahidkay
pushed a commit
that referenced
this pull request
Oct 30, 2024
refs: #9404 refs: #10336 refs: #10319 The cleaned up code is benign. it was designed to run once and has served its purpose. Removing it shouldn't affect anything. No scaling consequences. None The wallet upgrade was included in A3P-integration testing until three days ago. #10319 has been tested since 5 days ago without incident. removing benign dead code doesn't require extra tests. There is no *requirement* that this change be included in U18, so if it causes problems or gives anyone the willies, it can wait for the next release, but it's ready now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9404
Description
In #8445, we repaired legacy smartWallets. This removes the code that ran in upgrade15 that did the cleanup.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
No tests should be removed.
Upgrade Considerations
There is no hurry to merge this code on chain. If the PR merges soon, it'll be included in upgrade 18.