Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: allow workerThreads in swingset-vat #10848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

turadg
Copy link
Member

@turadg turadg commented Jan 14, 2025

closes: #9392

Description

Try enabling workerThreads (Ava default) to reduce GC flakes.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

Once this is green, merge and close #9392. If it recurs then reopen (and we'll know this doesn't solve the flakiness.)

Upgrade Considerations

none

Copy link

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: e7eaf01
Status: ✅  Deploy successful!
Preview URL: https://b1dee6db.agoric-sdk.pages.dev
Branch Preview URL: https://9392-ava-workerthreads.agoric-sdk.pages.dev

View logs

@turadg turadg added the bypass:integration Prevent integration tests from running on PR label Jan 14, 2025
@turadg turadg requested review from mhofman and dckc January 14, 2025 20:54
@turadg turadg marked this pull request as ready for review January 14, 2025 20:54
@turadg turadg requested a review from a team as a code owner January 14, 2025 20:54
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for asking, but I feel out of my depth here

@turadg turadg requested a review from gibson042 January 14, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bypass:integration Prevent integration tests from running on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake in SwingSet gc test
2 participants