test: remove redundant contractGovernor test #10907
Draft
+0
−952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's thoroughly covered in bootstrap and a3p tests now. This takes over two minutes on my MacBook Pro without adding any coverage. Moreover it's a style of test we want to avoid going forward.
|
This needs more work to refactor what was depending on these files. I'm leaving R4R to get feedback on the removal per se. |
There was a problem hiding this comment.
I don't think that we have other tests that check what oneVoterValidate() verifies. I don't know of other tests of offerFilters. (look for voteonOfferFilter.)
There are plenty of tests of API invocation and changing governed params, as well as updating electorates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #10906
Description
What
swingsetTests/contractGovernorwas written to cover is now thoroughly covered in bootstrap and a3p tests.Moreover it takes two minutes on a MBP and it's a style of test we want to avoid going forward.
So this removes a suite that has costs and no added value.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
no loss in coverage
Upgrade Considerations
n/a