Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test walletFactory upgrade on top of upgrade-11 #8308

Closed
wants to merge 15 commits into from
Closed

test walletFactory upgrade on top of upgrade-11 #8308

wants to merge 15 commits into from

Conversation

dckc
Copy link
Member

@dckc dckc commented Sep 5, 2023

closes: #8305

Description

  • pre tests:
    • check that walletFactory is not upgraded
    • check that published.boardAux has no children
  • actions:
    • install walletFactory upgrade bundle:
      • run proposal builder build-walletFactory-upgrade.js to generate bundle
      • mint-ist.sh to fund installation (send ATOM from a whale/validator to gov1; open a vault)
      • install-bundle on chain
    • install game1 bundle likewise
    • propose upgrade core-eval for walletFactory, game1
    • make an NFT trade using game1
  • tests:
    • test that walletFactory is upgraded
    • test that boardAux has displayInfo for all well-known brands
    • test that an NFT trade using game1 succeeded

Security / Scaling Considerations

nothing new

Documentation Considerations

A discussion of the upgrade proposal should be shared via community.agoric.com

Testing Considerations

This is a long way from testing that every aspect of walletFactory remains working after an upgrade.

Upgrade Considerations

not addressed:

dckc added 15 commits September 5, 2023 13:19
@dckc
WIP: non-endo board marshal support
d8d9f5e 
The ava tests in upgrade-tests don't seem to run in a hardened JS env
yet.
@dckc
test: boardAux has displayInfo for all well-known brands
f3896f9 
except timer
@dckc
chore: boardAux bash tests were ported to js
e4163c7
@dckc
refactor(upgrade-tests): factor swingStore-lite out of vat-status
9cf8b8a
@dckc
chore: move boardAux tests to upgrade-11
10f38ef
@dckc
chore: move walletFactory upgrade from 12 to 11
d7f9f46
@dckc
chore: run js tests as part of test.sh in 11
725fc4f
@dckc
build(upgrade-tests): better-sqlite3
7f35fb3
@dckc
chore: hoist mint-ist etc. for use in 11 or 12
42cbd29
@dckc
chore: COPY shared .js test files in agoric-upgrade-11
e5778c7
@dckc
fixup! chore: run js tests as part of test.sh in 11
12675d0
@dckc
test: walletFactory has been upgraded once
b6c78a0
@dckc
chore: move wallet-all-ertp 12 -> 11
34de2a8
@dckc
chore: move walletFactory stuff to its own layer
0d892e7
@dckc
chore: add agoric-upgrade-11wf layer
82f200e
This was referenced Sep 6, 2023
Closed
Merged
@dckc
Copy link
Member Author

dckc commented Sep 6, 2023

back-port approach (#8311) turns out to be relatively straightforward

@dckc dckc closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test of walletFactory contract upgrade on top of upgrade-11
1 participant
@dckc