support for watchedPromises in fakeVirtualSupport #8661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
changed the base branch from
release-mainnet1B
to
dev-upgrade-wallet-factory-2
mhofman
approved these changes
Dec 15, 2023
Comment on lines
162
to
168
| function allocatePromiseID() { | ||
| const exportID = nextExportID; | ||
| nextExportID += 1; | ||
| return exportID; | ||
| } |
There was a problem hiding this comment.
It would feel more consistent to use a separate ID
Suggested change
| function allocatePromiseID() { | |
| const exportID = nextExportID; | |
| nextExportID += 1; | |
| return exportID; | |
| } | |
| let nextPromiseID = 1; | |
| function allocatePromiseID() { | |
| const promiseID = nextPromiseID; | |
| nextPromiseID += 1; | |
| return promiseID; | |
| } |
Chris-Hibbert
force-pushed
the
8618-fakeVirtual-watchedPromises
branch
from
cb435a5 to
b5bc7e2
Compare
Chris-Hibbert
added a commit
that referenced
this pull request
Jan 16, 2024
* test: support for watchedPromises in fakeVirtualSupport Needed by #8488 * chore: update allocatePromiseID to use nextExportID * chore: distinct ID range for proises
mhofman
pushed a commit
that referenced
this pull request
Jan 19, 2024
* test: support for watchedPromises in fakeVirtualSupport Needed by #8488 * chore: update allocatePromiseID to use nextExportID * chore: distinct ID range for proises
mhofman
pushed a commit
that referenced
this pull request
Jan 19, 2024
anilhelvaci
pushed a commit
to Jorge-Lopes/agoric-sdk
that referenced
this pull request
Mar 4, 2024
…ic#8772) * test: support for watchedPromises in fakeVirtualSupport Needed by Agoric#8488 * chore: update allocatePromiseID to use nextExportID * chore: distinct ID range for proises
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by #8488
refs: #8488
refs: #8618
Description
Move the support for watchedPromises in #8618 from master to release
Security Considerations
N/A
Scaling Considerations
N/A
Documentation Considerations
None
Testing Considerations
Includes updates to tests.
Upgrade Considerations
yes.