Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies to community-dev #933

Merged
merged 3 commits into from
Jan 29, 2024
Merged

chore: update dependencies to community-dev #933

merged 3 commits into from
Jan 29, 2024

Conversation

0xpatrickdev
Copy link
Member

@0xpatrickdev 0xpatrickdev commented Jan 28, 2024

To Do:

  • Update tests for test-callSpread.js. It's reliant on setupBasicMints and zoeTestHelpers which are no longer exported in @agoric/zoe master but not upgrade-13 / community-dev.

This failure is only with yarn install, not agoric install which CI still uses.

import { setup } from '@agoric/zoe/test/unitTests/setupBasicMints.js';
import { assertPayoutDeposit } from '@agoric/zoe/test/zoeTestHelpers.js';
  Uncaught exception in snippets/zoe/contracts/test-callSpread.js

  Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/0xpatrick/repos/agoric-documentation/node_modules/@agoric/zoe/test/unitTests/setupBasicMints.js' imported from /Users/0xpatrick/repos/agoric-documentation/snippets/zoe/contracts/test-callSpread.js

  ✖ snippets/zoe/contracts/test-callSpread.js exited with a non-zero exit code: 1

@0xpatrickdev 0xpatrickdev marked this pull request as ready for review January 28, 2024 20:02
@0xpatrickdev 0xpatrickdev requested review from turadg and dckc January 28, 2024 20:02
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little fuzzy on some of the details.

I trust ci is checking the essential stuff.

Comment on lines +54 to +58
"@endo/bundle-source": "2.5.2-upstream-rollup",
"@endo/eventual-send": "^0.17.2",
"@endo/init": "^0.5.56",
"@endo/promise-kit": "^0.2.56",
"@endo/ses-ava": "^0.2.40",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not obvious how these are related to community-dev.

Are they from package.json files from u13? Got a pointer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ses": "^0.16.1",
"ses": "^0.18.8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem related to community-dev. hm.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

community-dev / upgrade 13 uses 0.18.4: https://github.com/Agoric/agoric-sdk/blob/5a6cdeb0c18ae9700d706445acf402f8d1e873c3/yarn.lock#L12045.

This particular change is for Node 18.x compat. I can amend cf859c6 and add a separate commit for this to make it clear if you'd like

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A separate commit might have been ideal but is probably not cost-effective now. This will change soon-ish anyway.

Thanks for the details here in the PR comments.

@0xpatrickdev 0xpatrickdev merged commit 12fb90c into main Jan 29, 2024
4 checks passed
@0xpatrickdev 0xpatrickdev deleted the chore/deps branch January 29, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants