-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies to community-dev
#933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little fuzzy on some of the details.
I trust ci is checking the essential stuff.
"@endo/bundle-source": "2.5.2-upstream-rollup", | ||
"@endo/eventual-send": "^0.17.2", | ||
"@endo/init": "^0.5.56", | ||
"@endo/promise-kit": "^0.2.56", | ||
"@endo/ses-ava": "^0.2.40", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not obvious how these are related to community-dev.
Are they from package.json files from u13? Got a pointer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I grabbed the versions from yarn.lock
, lines 1323 - 1523:
https://github.com/Agoric/agoric-sdk/blob/5a6cdeb0c18ae9700d706445acf402f8d1e873c3/yarn.lock#L1328
https://github.com/Agoric/agoric-sdk/blob/community-dev/yarn.lock#L1328
"ses": "^0.16.1", | ||
"ses": "^0.18.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem related to community-dev. hm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
community-dev
/ upgrade 13 uses 0.18.4
: https://github.com/Agoric/agoric-sdk/blob/5a6cdeb0c18ae9700d706445acf402f8d1e873c3/yarn.lock#L12045.
This particular change is for Node 18.x compat. I can amend cf859c6 and add a separate commit for this to make it clear if you'd like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A separate commit might have been ideal but is probably not cost-effective now. This will change soon-ish anyway.
Thanks for the details here in the PR comments.
uses
community-dev
foragoric
dependencies instead ofbeta
uses
[email protected]
for node 18.19 compatmotivation: drop node 16 EOL ci is failing
To Do:Update tests for.test-callSpread.js
. It's reliant onsetupBasicMints
andzoeTestHelpers
which areno longerexported in@agoric/zoe
master
but notupgrade-13
/community-dev
This failure is only with
yarn install
, notagoric install
which CI still uses.