-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages don't work - Same results each time. #104
Comments
What operating system do you run? Does hosting LibreY at the root domain give any issues? (e.g: https://search.ahwx.org) |
Debian 12, and I'm not sure , I can change my nginx conf to redirect a subdomain to /x/ and test it if you'd like, but personally I would have, or want to have the code able to function regardless of if it's at the base directory or not. For the "Pages 1, 2, 3, 4" not working, odd that it worked in the previous instance but not the latest instance. Not sure whats goin on there, or what was changed. |
Root Domain version here (same as /x/LibreY) Images tab:
Video tab does not provide any thumbnails
Torrents tab: (redacted, not the full extent of errors but most repeated, here were the seperate issues I glanced over and saw)
|
I agree, but I'd want to know if that could be an easy fix, at least temporarily. Debian 12 should be fine, all of my instances are also running on Debian 12. |
I'll look at this tomorrow, it's 02:09 am currently and my brain doesn't want to continue anymore :P |
Fair enough. Same errors unfortunately! Actually I caught errors I didn't notice before, with the torrent page lol so more errors. |
No worries! Have a good night. |
Please post your |
PHP 8.3 is not in the Debian 12 bookworm repositories. This is likely because you installed it from the Yet, all of these issues still occur in the Docker image in #99, which runs on PHP 8.3. From the circumstances, this issue with the same results may be due to results being cached, which may not respect what page you're on. |
Without installing |
I believe this might be an oversight when implementing caching, looks like the different page numbers arent regarded when caching takes place. Hopefully this should be a simple fix; I have not been testing page 2 at all in any recent changes so its likely that this was broken in a much earlier revision As for running librex on the root of the domain, i think thats currently necessary, simply due to the way that the different php files are included internally. Theres probably a pretty easy fix for this too, as i dont see any reason why librex shouldnt be able to run at non-root locations. |
Fixed a bunch of these errors in #105 . When using php development server, I'm able to put LibreY running in a subdirectory, so that might be an issue with nignx. I'll do a bit of testing now. I'm not sure what the issue with the video search is, possibly the invidious instance used for results is down. I've been working on #81 so that should eliminate that issue eitherway. |
I don't see a difference at all between running it on root domain or sub directory, what makes you believe that's an issue ? And Sorry I've been busy and haven't gotten back on this subject yet. Just doing a quick response rn. If you want I can send the version where pages work, or search through myself and check all of what was changed. Or better yet, log the date of the version that works page wise, upload the version where pages work, upload the most recent version, and GitHub will automatically compare all changes, won't be the best / ideal to tell exactly what it was that broke it but it will at least give some ideas as to what's been changed that could've done it.
Config.php between the version of LibRey that works and the version that doesn't , no difference. Default configuration pretty much. Can do if you want though 🤷 |
You could make a PR :)
Please still upload it :) |
Fixed here / more specifically here Proof of Concept located here
Considering that this commit fixed it, I don't see the necessity. And I verified, default config with no alterations. |
Since #105 has been merged, can this issue be closed? Not sure if theres anything else that's been missed. |
Can confirm the fix works. |
Closing due to inactivity by @dehlirious. |
My setup: PHP8.3-fpm + nginx
Instance here, no matter what page is pressed, same results exist. What gives? I'm not too certain what the cause is.
I updated to the latest instance and this was an issue, previously the page buttons worked fine as you can test here , the previous instance works fine.
Other issues that I'd like to bring up to get resolved:
Video tab does not provide any thumbnails! with this err
I'm able to sort through and fix some myself but if I don't have to why bother, right?
Anyway can you guys update me with where you're at in the project, anything you'd need, things you want? If I can contribute in a usable way towards development whether it be optimization, bug fixing, new feature implementation, I'd like to but I need to know what is desired so I'm not just working towards things only my single instance will make use of.
The text was updated successfully, but these errors were encountered: