Fix fetching other pages when first page is cached #105
+16
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ahwxorg could you please review this PR. In my opinion I think its ready to merge |
Ahwxorg
reviewed
Jan 3, 2024
There was a problem hiding this comment.
Looks good, is this PR ready to merge? (@davidovski)
|
One small fix is necessary |
|
Done, I'll look into that about the "Latest Commit" text not working if its not a checked out repo, probably an issue for a different day though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issues found in #104.
In #96 cache was changed to using the text query as the cache key, however this did not account for the page or language. Added those to the key.
Fixed selecting page on qwant image search.
Looks like the config option for bittorrent trackers is misspelled in the config, so I've fixed that. Added a couple of lines so it still works with old configs. (to be removed in the future)