Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the monkey patch of add_foreign_key #10

Open
wants to merge 1 commit into
base: rails-5-2
Choose a base branch
from

Conversation

jimgrimmett
Copy link

The function prototype in the money patch is:
def add_foreign_key(referencing_table_name, referencing_field_name, referenced_table_name, referenced_field_name = :id)

The function protoype in ActiveRecord is:
def add_foreign_key(to_table, options)

This means that many of the documented ways to call add_foreign_key in a migration do not work.

Please feel free to tell what I am missing here and suggest a better solution, but with this change in place, everything is working again.

…pe to the one in activerecord. Not clear that it is needed.
@jakub-tokaj-ah
Copy link

@jimgrimmett thanks for the PR, but as the repository readme says: https://github.com/AirHelp/partitioned#this-fork-is-no-longer-maintained

We are no longer maintaining this fork. If you need some functionality feel free to create and maintain your own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants