-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force focus into HTML5 input #273
Draft
jordanjones243
wants to merge
2
commits into
beta
Choose a base branch
from
jjones/datepickerImprovements
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces a new method to force focus into the datepicker's input field, ensuring the user can immediately interact with the datepicker after it's rendered. Additionally, it updates several development dependencies. Sequence diagram for datepicker focus behaviorsequenceDiagram
participant User
participant DatePicker
participant Input
Note over DatePicker: Component initialized
DatePicker->>DatePicker: forceInputFocus()
alt Not range mode
DatePicker->>Input: focus()
else Range mode with complete start date
alt Complete end date
DatePicker->>Input: focus()
else Incomplete end date
DatePicker->>Input: focus('endDate')
end
else Other cases
DatePicker->>Input: focus()
end
Class diagram for AuroDatePicker updatesclassDiagram
class AuroDatePicker {
-forceInputFocus()
+focus(focusInput)
+convertTime(time)
+addEventListener()
+valueEnd
+value
+range
}
note for AuroDatePicker "Added forceInputFocus() method
to handle automatic focus behavior"
State diagram for datepicker focus statesstateDiagram-v2
[*] --> Initial
Initial --> SingleInputFocused: Not range mode
Initial --> StartDateFocused: Range mode & complete start date
StartDateFocused --> EndDateFocused: Incomplete end date
StartDateFocused --> SingleInputFocused: Complete end date
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Before Submitting this pull request:
Development
sectionnote: all pull requests require at least one linked ticket
Ready For Review
, all ticket's linked underDevelopment
must have their status changed toReady For Review
as wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Enhancements: