Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed according to new main branch changes footer.jsx #230

Closed
wants to merge 4 commits into from

Conversation

devxMani
Copy link

@devxMani devxMani commented Oct 14, 2024

#56 is done you can check
working fine for me
image

Copy link

netlify bot commented Oct 14, 2024

👷 Deploy request for delightful-daifuku-a9f6ea pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4586546

@@ -57,7 +58,6 @@ const Footer = () => {
};

try {
//This is the URL you can use if you are working on local machine if creating error in finding backendURL so use this in fetch request = 'http://localhost:8080/api/feedback
const response = await fetch(`${backendURL}/api/feedback`, {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devxMani why remove this comment?
You have removed all the comments wherever it wsa before. Please put those comments back

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlfiyaSiddique i'll create a new pr for this

@AlfiyaSiddique
Copy link
Owner

It is better if you can make the changes in this same branch(PR) only but if it's hard for you it's fine, but please try to open only one PR for one issue.

@devxMani
Copy link
Author

@AlfiyaSiddique if this working fine can you add level 2 to this

@AlfiyaSiddique
Copy link
Owner

@devxMani can you please update the PR, the deploy preview is not working because of this I guess

@AlfiyaSiddique
Copy link
Owner

@devxMani any updates?

@devxMani
Copy link
Author

@AlfiyaSiddique I'll do it give me some time

@AlfiyaSiddique
Copy link
Owner

@devxMani any updates? You can give us a date by when you will continue, since there are chances of PR getting closed due to no activity

@AlfiyaSiddique
Copy link
Owner

@devxMani this Pr will get closed tomorrow if no activity found

@devxMani
Copy link
Author

devxMani commented Nov 8, 2024

@AlfiyaSiddique close..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants