-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made the navbar sticky. #353
Conversation
✅ Deploy Preview for delightful-daifuku-a9f6ea ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you @vidhi-github for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.
@vidhi-github it's not working, you can check the deploy preview. Please test |
@vidhi-github any updates? |
It's working only on first 100vh port height. As asked to make the navbar sticky at first 100vh height. I did check it. Thank you. |
@vidhi-github you have misunderstood I think As you can see in the picture the navbar does not appearing: Please fix |
@vidhi-github any updates? |
Sorry Sir currently my exams r going on I would like to close this issue ...kindly do not merge this as the problem isn't solved. Thanks alot for ur cooperation. |
What does this PR do?
Makes the navbar sticky after first 100vh.
The handleScroll function now checks if window.scrollY (the scroll position) is greater than window.innerHeight, which represents 100vh.
When isSticky becomes true, the navbar will be fixed to the top with additional classes like bg-white and shadow-md.
Fixes # (issue)
Issue No.: 269
How should this be tested?
deployed the project on vercel.
I am facing the favicon issue ,, in my deployment...rest all is correct .. I have thoroughly checked my code.
I have made the navbar sticky.
I wanted to ask regarding this favicon issue how can I avoid it,, like it gives favicon error 404 error. Can u help me that plz.
Checklist
Required
console.logs