Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the navbar sticky. #353

Closed
wants to merge 4 commits into from

Conversation

vidhi-github
Copy link

What does this PR do?

Makes the navbar sticky after first 100vh.

The handleScroll function now checks if window.scrollY (the scroll position) is greater than window.innerHeight, which represents 100vh.

When isSticky becomes true, the navbar will be fixed to the top with additional classes like bg-white and shadow-md.

Fixes # (issue)

Issue No.: 269

How should this be tested?

deployed the project on vercel.
I am facing the favicon issue ,, in my deployment...rest all is correct .. I have thoroughly checked my code.
I have made the navbar sticky.

I wanted to ask regarding this favicon issue how can I avoid it,, like it gives favicon error 404 error. Can u help me that plz.

  • Test 1
  • Test 2

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing guide
  • Self-reviewed my own code
  • Checked for warnings, there are none
  • Removed all console.logs
  • The changes don't cause any responsiveness issues

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for delightful-daifuku-a9f6ea ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/delightful-daifuku-a9f6ea/deploys/671e80fca548b2a639ac2f64
😎 Deploy Preview https://deploy-preview-353--delightful-daifuku-a9f6ea.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @vidhi-github for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.

@AlfiyaSiddique
Copy link
Owner

@vidhi-github it's not working, you can check the deploy preview. Please test

@AlfiyaSiddique
Copy link
Owner

@vidhi-github any updates?

@vidhi-github
Copy link
Author

vidhi-github commented Nov 4, 2024

It's working only on first 100vh port height. As asked to make the navbar sticky at first 100vh height. I did check it.

Thank you.

@AlfiyaSiddique
Copy link
Owner

@vidhi-github you have misunderstood I think
The requirement is as follows:
In the first 100vh, the navbar should not be sticky when scrolling:
After the first 100vh is scrolled (passed) the navbar should appear on top as sticked

As you can see in the picture the navbar does not appearing:
image

Please fix

@AlfiyaSiddique
Copy link
Owner

@vidhi-github any updates?

@vidhi-github
Copy link
Author

Sorry Sir currently my exams r going on I would like to close this issue ...kindly do not merge this as the problem isn't solved.

Thanks alot for ur cooperation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants