Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Recipe For The Day Suggestion section #444

Merged
merged 7 commits into from
Nov 10, 2024

Conversation

sanchitc05
Copy link
Contributor

@sanchitc05 sanchitc05 commented Nov 10, 2024

Fixes #328

What does this PR do?

This PR introduces the "Recipe of the Day" feature, which fetches a random recipe from the backend API and displays it in the application. This feature enhances user engagement by providing daily culinary inspiration.

Fixes #328 (Implement Recipe of the Day feature)

New Dependencies

  • axios: For making HTTP requests to the backend API.

How should this be tested?

To test this feature, follow these steps:

  1. Ensure the backend API is running and accessible.
  2. Navigate to the section of the application where the RecipeOfTheDay component is included.
  3. Verify that a random recipe is displayed correctly.
  4. Check the loading spinner appears while the recipe is being fetched.
  5. Test the error handling by temporarily disabling the API or using an invalid endpoint to ensure appropriate error messages are displayed.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing guide
  • Self-reviewed my own code
  • Checked for warnings, there are none
  • Removed all console.logs
  • The changes don't cause any responsiveness issues

Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for delightful-daifuku-a9f6ea ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/delightful-daifuku-a9f6ea/deploys/6730b470b3d664aa923f16cb
😎 Deploy Preview https://deploy-preview-444--delightful-daifuku-a9f6ea.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanchitc05
Copy link
Contributor Author

@AlfiyaSiddique Please look into the pr now and let me know if everything's good.

@AlfiyaSiddique
Copy link
Owner

@sanchitc05 there is 2 Recipe of the day sections in your code:
image

Please fix it can't merge this with such issues

@AlfiyaSiddique AlfiyaSiddique added gssoc-ext For GSSOC Extended Contribution. level 2 GSSOC level 2 Contribution - 25 points hacktoberfest-accepted labels Nov 10, 2024
@AlfiyaSiddique
Copy link
Owner

@sanchitc05 not working still merging

@AlfiyaSiddique AlfiyaSiddique merged commit dd70aba into AlfiyaSiddique:master Nov 10, 2024
5 checks passed
Copy link

🎉 Thank you @sanchitc05 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@sanchitc05
Copy link
Contributor Author

Thank you so much for your cooperation @AlfiyaSiddique ✨ It means a lot! The GSSOC has ended but I'll still be in touch with you in case you need any other modifications or addition to your project.
Regards,
Sanchit Chauhan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext For GSSOC Extended Contribution. hacktoberfest-accepted level 2 GSSOC level 2 Contribution - 25 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: Recipe For The Day Suggestion section
2 participants