Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openhands-agent comment detection #5

Merged
merged 16 commits into from
Nov 29, 2024
Merged

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Nov 28, 2024

This PR fixes the issue with openhands-agent comments not being properly detected in the monitor interface.

Changes:

  • Made comment detection more flexible by using case-insensitive matching
  • Added more variations of success/failure messages to better match actual bot responses
  • Added comprehensive tests for both issue and PR comment detection

The changes have been tested and verified to work with the current bot message patterns.

- Made comment detection more flexible by using case-insensitive matching
- Added more variations of success/failure messages
- Added comprehensive tests for both issue and PR comment detection
Copy link

vercel bot commented Nov 28, 2024

@openhands-agent is attempting to deploy a commit to the all-hands-ai team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @openhands-agent as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @openhands-agent as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the all-hands-ai team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

- Made comment detection more flexible by using case-insensitive matching
- Added more variations of success/failure messages
- Added support for both openhands-agent and github-actions[bot] comments
- Added comprehensive tests including integration test with real data
- Added default 30-day window for fetching activities
- Skip issues and PRs without comments
- Added comments count to issue and PR interfaces
- Fixed pagination by properly handling Link header
- Added logging to help with debugging
- Added integration test that verifies real data
- Moved integration tests to __integration_tests__ directory
- Added separate npm script for running integration tests
- Excluded integration tests from regular test runs
- Added comprehensive documentation for both unit and integration tests
- Fixed imports in integration tests
- Removed accidentally added repository submodule
- Fixed template literal type error in GitHub service
- Use bracket notation consistently for accessing environment variables
- Fix TypeScript error in import.meta.env access
@neubig neubig merged commit 68c5b8d into main Nov 29, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants