Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update libczi and actions #115

Merged
merged 8 commits into from
Apr 2, 2024
Merged

update libczi and actions #115

merged 8 commits into from
Apr 2, 2024

Conversation

toloudis
Copy link
Collaborator

@toloudis toloudis commented Mar 22, 2024

Brings libCZI up to latest runtime, with updates for minor api changes.

Also throw in some version bumps for github actions to remove actions warnings about node version.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (2e2faee) to head (0b37d35).
Report is 2 commits behind head on main.

❗ Current head 0b37d35 differs from pull request most recent head 48c6e45. Consider uploading reports for the commit 48c6e45 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files           3        3           
  Lines         148      148           
=======================================
  Hits          146      146           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toloudis toloudis changed the title update libczi and version update libczi and actions Mar 23, 2024
@toloudis toloudis marked this pull request as ready for review March 23, 2024 01:02
with:
submodules: true
- name: setup python
uses: actions/setup-python@v4
uses: actions/setup-python@v5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SWE recommended me using actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c which is the latest version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be doing that across the board? Do we trust these major mainstream actions like actions/checkout or actions/setup-python enough? I felt this was more relevant for lesser-known actions.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @griffinfujioka can help with this one.

@toloudis toloudis merged commit d6a926f into main Apr 2, 2024
20 checks passed
@toloudis toloudis deleted the feature/update-libczi-2024-03 branch April 2, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants