-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update libczi and actions #115
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 3 3
Lines 148 148
=======================================
Hits 146 146
Misses 2 2 ☔ View full report in Codecov by Sentry. |
with: | ||
submodules: true | ||
- name: setup python | ||
uses: actions/setup-python@v4 | ||
uses: actions/setup-python@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SWE recommended me using actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c
which is the latest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be doing that across the board? Do we trust these major mainstream actions like actions/checkout
or actions/setup-python
enough? I felt this was more relevant for lesser-known actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @griffinfujioka can help with this one.
Brings libCZI up to latest runtime, with updates for minor api changes.
Also throw in some version bumps for github actions to remove actions warnings about node version.