Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 159 rig json #160

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Fix 159 rig json #160

merged 3 commits into from
Sep 15, 2024

Conversation

jtyoung84
Copy link
Contributor

@jtyoung84 jtyoung84 commented Sep 15, 2024

Closes #159

  • Short-term patch to loosen restriction of pydantic validation and serialization. If a model json file is json serializable, we'll build the metadata record and flag the record as being invalid instead of raising an error and terminating the GatherMetadataJob
  • Adds problematic rig.json in test folder
  • Long-term, this logic should move to the aind-data-schema repo

@jtyoung84 jtyoung84 requested a review from dyf September 15, 2024 00:45
@jtyoung84 jtyoung84 merged commit 4b40d1e into dev Sep 15, 2024
3 checks passed
@jtyoung84 jtyoung84 deleted the fix-159-rig-json branch September 15, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with deserialization of rig
2 participants