Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warmup #1304

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix warmup #1304

wants to merge 4 commits into from

Conversation

XX-Yin
Copy link
Collaborator

@XX-Yin XX-Yin commented Jan 10, 2025

Pull Request instructions:

  • Please follow the update protocol
  • Answer the questions below in detail. Your responses will be emailed to experimenters.
  • If the experimenters must do anything new, provide detailed step by step instructions on the wiki
  • If computer maintainers need to manually update anything, provide detailed step by step instructions
  • Use markdown syntax in order for your comments to be rendered reliably in the email: "1." instead of "1)", use four spaces for indents.
  • If you use the keyword "skip email" in the title, it will skip the email updates
  • Merges from "develop" into "production_testing" should use the keyword "production merge" in the title for reliable indexing of updates
  • Merges from "production_testing" into "main" should use the keyword "update main"

Describe changes:

Explicitly set the UpdateParameter to 1 after the warmup is turned off.

What issues or discussions does this update address?

https://github.com/AllenNeuralDynamics/aind-behavior-blog/issues/840#issuecomment-2584676842

Describe the expected change in behavior from the perspective of the experimenter

No

Describe any manual update steps for task computers

No

Was this update tested in 446/447?

I can't repeat this issue on my side, but this PR could potentially solve it.

@XX-Yin XX-Yin requested review from alexpiet and hanhou January 14, 2025 20:45
Copy link
Collaborator

@alexpiet alexpiet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the update parameters variable does. @hanhou you might be better prepared to review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants