Fix missing statusText and status code #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, `resp` didn't have `statusText` and `status` as properties. Instead, those properties were accessible through either `resp.rawRequest` or through the value returned from calling `model.fetch` (both, I believe are the xhr instance) Related to AmpersandJS#31
|
Looks fine. I also verified #38 for this one. Cheers! |
|
Looks good. I wonder if this is something that changed when we moved to xhr2 and also why test wouldn't have caught this. |
|
I think this was definitely cause by the switch to xhr2, where the The tests didn't catch this because the tests use manually-triggered Anyway, I've merged the code with the last PR |
|
K, the testing is probably a separate issue. |
imo
wraithgar
added a commit
that referenced
this pull request
Jan 25, 2016
Fix missing statusText and status code
|
published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
respdidn't havestatusTextandstatusas properties. Instead, those properties were accessible through eitherresp.rawRequestor through the value returned from callingmodel.fetch(both, I believe are the xhr instance)Related to #31
(this might be worth waiting for #38 to be accepted, so I could merge that into this branch, to avoid conflicts)