[WIP] Allow changing to input element from textarea element when type
is changed from "textarea"
#78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when the inputView's
type
changed from "textarea" to something else ("text", "number", etc.), thehandleTypeChange
method would not handle changing the textarea to an input, like it would for changing an input to a textarea.This builds on #77, a non-breaking change. This change, however, is a breaking one, and should be released as a major version after the previous PR gets released as a patch.
The reason this is a breaking change is because previously, setting
type
to "textarea" was not needed to render as a textarea. If "textarea" was in thetemplate
thentype
could be anything and it would not matter: a textarea would still render.Todo: