Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Allow changing to input element from textarea element when type is changed from "textarea" #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhritzkiv
Copy link
Member

@dhritzkiv dhritzkiv commented Nov 22, 2017

Before this change, when the inputView's type changed from "textarea" to something else ("text", "number", etc.), the handleTypeChange method would not handle changing the textarea to an input, like it would for changing an input to a textarea.

This builds on #77, a non-breaking change. This change, however, is a breaking one, and should be released as a major version after the previous PR gets released as a patch.

The reason this is a breaking change is because previously, setting type to "textarea" was not needed to render as a textarea. If "textarea" was in the template then type could be anything and it would not matter: a textarea would still render.


Todo:

  • add tests
  • version bump
  • update documentation
  • add release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant