Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug vaguely referenced in #112 where listening to events could be messed up when using
setOnce
.It also:
set
call be bound tothis
, which makes the call more powerful (this is also referenced in Suggestions for custom Datatypes #112)onSet
method for custom datatypes, which is designed to allow for initialization of custom datatypes after they pass all their tests (type check,setOnce
, etc) but before events are called. Case here is forstate
type setting up child event bubbling.compare
method to only do compare, child bubbling moved to newonSet
method.Currently does not update docs. #112 has been out there for awhile so I'm not sure how well this PR will be received. However, if I get interest from the core team, I'll update the docs to reflect the new changes. I'll even throw in some documentation for the
state
datatype (from #142 ). :)