Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Use correct schedule for calculate_producer_wake_up_time #2149

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jan 27, 2024

Noticed wrong schedule being used while debugging other issues. Reverts back to main behavior.
Also avoid unneeded copy of block_signing_authority.

@heifner heifner requested review from greg7mdp and linh2931 January 27, 2024 17:29
@heifner heifner added the OCI Work exclusive to OCI team label Jan 27, 2024
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to your changes. Why did chainbase core dump in CICD?

@greg7mdp
Copy link
Contributor

I have the same ci/cd error in my pr for ubuntu22repro that you have in your PR's ubuntu20.

@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: BUG
summary: Use correct schedule for calculate_producer_wake_up_time, revert to previous implementation.
Note: end

@heifner heifner merged commit ee218c6 into hotstuff_integration Jan 30, 2024
25 of 26 checks passed
@heifner heifner deleted the active-schedule branch January 30, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants