Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment finalizer_policy's generation when set_finalizers is executed. #2388

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Increment finalizer_policy's generation when set_finalizers is executed. #2388

merged 1 commit into from
Apr 9, 2024

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Apr 8, 2024 •
edited
Loading

Resolves #2345

The finalizer_policy struct in contracts does not have a generation member.
In this PR, when the set_finalizers host function is executed, we increment the generation number of the finalizer_policy to the the active policy generation number plus one.

@greg7mdp greg7mdp changed the base branch from main to hotstuff_integration April 8, 2024 20:34
@greg7mdp greg7mdp requested review from heifner and linh2931 April 8, 2024 20:36
@greg7mdp greg7mdp closed this Apr 8, 2024
@greg7mdp greg7mdp reopened this Apr 8, 2024
@greg7mdp greg7mdp merged commit 232e95b into hotstuff_integration Apr 9, 2024
67 of 72 checks passed
@greg7mdp greg7mdp deleted the gh_2345 branch April 9, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: set_finalizers should take finalizer policy without the generation number
3 participants
@greg7mdp @heifner @linh2931