Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2P: Resolve endpoints on re-connect attempts #525

Closed
heifner opened this issue Aug 12, 2024 · 2 comments · Fixed by #825, #826, #840, #841 or #853
Closed

P2P: Resolve endpoints on re-connect attempts #525

heifner opened this issue Aug 12, 2024 · 2 comments · Fixed by #825, #826, #840, #841 or #853
Assignees
@heifner
Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.0.3

Comments

@heifner
Copy link
Member

heifner commented Aug 12, 2024

Currently net_plugin resolves endpoints at startup and then reuses the tcp::resolver::results_type for any re-connection attempt. If resolve fails at startup then the resolve is not attempted again. Also net_plugin reports an unhelpful "Element not found` error.

See #523 (comment)
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Aug 12, 2024
@heifner heifner mentioned this issue Aug 12, 2024
Closed
@heifner
Copy link
Member Author

heifner commented Aug 14, 2024

You do get a warn message on the first resolve, but since it never attempts the resolve again you only get the warn message once.

warn  2024-08-14T13:19:55.590 net-2     net_plugin.cpp:4638           operator()           ] Unable to resolve p2p.spring-beta.jungletestnet.io:9898 Host not found (authoritative)

@spoonincode
Copy link
Member

fwiw, (depending on complexity of course) imo a fix for this should go in to stable release. It prevents the ability to do basic failover approaches via low TTL DNS records since clients won't see the updated record.

@bhazzard bhazzard added this to the Spring v1.0.2 milestone Sep 20, 2024
@bhazzard bhazzard added bug The product is not working as was intended. 👍 lgtm and removed triage labels Sep 20, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Sep 24, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Sep 25, 2024
This was referenced Sep 25, 2024
Merged
Merged
@heifner heifner linked a pull request Sep 26, 2024 that will close this issue
[5.0.3 -> 1.0.2] P2P: Resolve on reconnect #825
Merged
@heifner heifner mentioned this issue Sep 26, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Sep 26, 2024
@arhag arhag reopened this Sep 30, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in Team Backlog Sep 30, 2024
This was linked to pull requests Sep 30, 2024
Revert "[5.0.3 -> 1.0.2] P2P: Resolve on reconnect" #840
Merged
Revert "[1.0.2 -> main] P2P: Resolve on reconnect" #841
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Sep 30, 2024
@spoonincode spoonincode reopened this Sep 30, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in Team Backlog Sep 30, 2024
heifner added a commit that referenced this issue Oct 1, 2024
@heifner
GH-525 Remove dead code
c2d54ad
heifner added a commit that referenced this issue Oct 1, 2024
@heifner
GH-525 Minimum code changes to resolve on reconnect
f336eaf
@arhag arhag removed this from the Spring v1.0.2 milestone Oct 1, 2024
heifner added a commit that referenced this issue Oct 2, 2024
@heifner
GH-525 Use context of connection strand
c0e7226
heifner added a commit that referenced this issue Oct 2, 2024
@heifner
GH-525 Use very large timeout
4cf8f50
heifner added a commit that referenced this issue Oct 2, 2024
@heifner
GH-525 Remove call to update_endpoints which I thought I already remo…
c8dca0e 
…ved. Add additional debug statements.
heifner added a commit that referenced this issue Oct 2, 2024
@heifner
GH-525 Only close if socket open
a7bdcfe
spoonincode added a commit that referenced this issue Oct 2, 2024
@spoonincode
Merge pull request #868 from AntelopeIO/GH-525-p2p-resolve-main
80ad6d6 
[1.0.2 -> main] P2P: Resolve on reconnect
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Oct 2, 2024
heifner added a commit that referenced this issue Oct 2, 2024
@heifner
GH-525 bind_executor
3e3a59d
heifner added a commit that referenced this issue Oct 2, 2024
@heifner
GH-525 Use strand for socket
517b66d
This was linked to pull requests Oct 2, 2024
[1.0.2] Revert "[1.0.2] P2P: Resolve on reconnect - Take 2" #870
Merged
[1.0.2 -> main] Revert "[1.0.2] P2P: Resolve on reconnect - Take 2" #871
Merged
@arhag arhag reopened this Oct 2, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in Team Backlog Oct 2, 2024
heifner added a commit that referenced this issue Oct 2, 2024
@heifner
GH-525 Keep resolver alive until connect complete
6d5bea2
@heifner heifner mentioned this issue Oct 2, 2024
Merged
heifner added a commit that referenced this issue Oct 3, 2024
@heifner
GH-525 Capture endpoints
71174de
heifner added a commit that referenced this issue Oct 3, 2024
@heifner
GH-525 Extra logging
8641ecb
heifner added a commit that referenced this issue Oct 3, 2024
@heifner
GH-525 Create socket before connect
17537a9
heifner added a commit that referenced this issue Oct 3, 2024
@heifner
GH-525 Use unique_ptr for socket
ad1b923
heifner added a commit that referenced this issue Oct 7, 2024
@heifner
Merge branch 'release/1.0' into revert-870-revert-853-GH-525-p2p-resolve
ebd8e54
heifner added a commit that referenced this issue Oct 7, 2024
@heifner
GH-525 bind_executor to connection strand
4c9e293
heifner added a commit that referenced this issue Oct 7, 2024
@heifner
Merge remote-tracking branch 'spring/release/1.0' into revert-870-rev…
5c194a3 
…ert-853-GH-525-p2p-resolve
@heifner heifner linked a pull request Oct 7, 2024 that will close this issue
[1.0.3] P2P: Resolve on reconnect - Take 3 #879
Merged
@heifner heifner moved this from Todo to In Progress in Team Backlog Oct 7, 2024
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Oct 7, 2024
heifner added a commit that referenced this issue Oct 8, 2024
@heifner
Merge remote-tracking branch 'spring/release/1.0' into 853-GH-525-p2p…
7c57785 
…-resolve-main
@heifner heifner mentioned this issue Oct 8, 2024
Merged
@heifner heifner linked a pull request Oct 8, 2024 that will close this issue
[1.0.3 -> main] P2P: Resolve on reconnect - Take 3 #911
Merged
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Done
Milestone
Spring v1.0.3
5 participants
@bhazzard @heifner @arhag @spoonincode @enf-ci-bot